remove usages of controlTypes.roleLabels#12814
Merged
Conversation
5 tasks
michaelDCurran
approved these changes
Sep 8, 2021
Merged
5 tasks
feerrenrut
pushed a commit
that referenced
this pull request
Dec 13, 2021
…lle (PR #13160) Fixes #13158 PR #12814 replaced usages of deprecated controlTypes.roleLabels with role.displayString. However braille has its own mapping of roles to labels which should be used for abbreviations of roles for braille. The role label used for speech has been mistakenly used for a role of landmark.
feerrenrut
pushed a commit
that referenced
this pull request
Dec 14, 2021
…lle (PR #13160) Fixes #13158 PR #12814 replaced usages of deprecated controlTypes.roleLabels with role.displayString. However braille has its own mapping of roles to labels which should be used for abbreviations of roles for braille. The role label used for speech has been mistakenly used for a role of landmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Part of #12549
Summary of the issue:
controlTypes.roleLabelshas been deprecated, usages such as.controlTypes.roleLabels[controlTypes.Role.*]should be replaced to their equivalentcontrolTypes.Role.*.displayStringDescription of how this pull request fixes the issue:
Uses the Role enum to determine the role, and use the displayString instead of
roleLabels.Testing strategy:
Search the NVDA repo for "roleLabels".
Unit tests exist in
test_controlTypes.TestLabelsKnown issues with pull request:
None
Change log entries:
None needed
Code Review Checklist: