Ensure office app check is bound to window class

[LeonarddeR]

Link to issue number:

Fixes #12852

Summary of the issue:

Secure desktops were severly broken in Alpha.

Description of how this pull request fixes the issue:

First check for the proper window class before applying logic to detect office apps and versions.

Testing strategy:

T.B.D. I think we need a signed build for this.

Known issues with pull request:

None known

Change log entries:

None needed

Code Review Checklist:

• Pull Request description is up to date.
• Unit tests.
• System (end to end) tests.
• Manual testing.
• API is compatible with existing addons.
• User Documentation.
• Change log entry.
• Context sensitive help for GUI changes.
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests. See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/asm6s747iu08vskv/artifacts/output/nvda_snapshot_pr12854-23768,e8d92457.exe

See test results for failed build of commit e8d9245774

[LeonarddeR]

System tests failure seems unrelated.

[lukaszgo1]

Based on the log snipped I posted in #12852 I believe this fix would not be effective since fileUtils raises an error during execution of this line when trying to access productName of the LogonUI

[michaelDCurran]

For now At very least a try accept RuntimeError is required around the call to appModule.productName I think.

[LeonarddeR]

Here's another incarnation of the regression:

Traceback (most recent call last):
  File "core.py", line 702, in run
    IAccessibleHandler.pumpAll()
  File "IAccessibleHandler\__init__.py", line 946, in pumpAll
    if procFunc(*(focusWinEvent[1:])):
  File "IAccessibleHandler\__init__.py", line 613, in processFocusWinEvent
    NVDAEvent = winEventToNVDAEvent(winUser.EVENT_OBJECT_FOCUS, window, objectID, childID, useCache=False)
  File "IAccessibleHandler\__init__.py", line 473, in winEventToNVDAEvent
    if UIAHandler.handler and UIAHandler.handler.isUIAWindow(window):
  File "_UIAHandler.py", line 818, in isUIAWindow
    v=self._isUIAWindowHelper(hwnd),now
  File "_UIAHandler.py", line 757, in _isUIAWindowHelper
    isOfficeApp = appModule.productName.startswith(("Microsoft Office", "Microsoft Outlook"))
  File "baseObject.py", line 26, in __get__
    return self.fget(instance)
  File "appModuleHandler.py", line 413, in _get_productName
    self._setProductInfo()
  File "appModuleHandler.py", line 390, in _setProductInfo
    raise RuntimeError("processHandle is 0")
RuntimeError: processHandle is 0

[LeonarddeR]

I did a rewrite of my approach. In short, I really want to do the appModule.productName call only when the window class is wwg. IN the current situation of master, every call of _isUIAWindowHelper tried to get the appName

[codeofdusk]

Is this planned for merge?

[michaelDCurran]

Try build: https://ci.appveyor.com/api/buildjobs/1f3h90inubvxyih3/artifacts/output%2Fnvda_snapshot_try-pr12854-23780%2Cda61cfcd.exe

[michaelDCurran]

with try build:

• Verified that NVDA functioned on a secure desktop: could report focus with tab and shift+tab. NVDA menu could be read.
• With Use UIA in MS Word document option off, Verified that UIA was used in MS Word for a build above 16.0.13900.
• With Use UIA in MS Word document option off, Verified that UIA was not used in MS Word for build 16.0.13900.