Merged
Conversation
This was referenced Dec 1, 2021
Contributor
Author
|
One reporter has verified the PR resolves the issue. |
|
Tested in firefox 95 64 bit and Thunderbird Daily 96.0a1 (2021-11-30) (64-bit) Running on windows 11 64 bit. |
OzancanKaratas
approved these changes
Dec 1, 2021
Collaborator
OzancanKaratas
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for your work!
LeonarddeR
approved these changes
Dec 1, 2021
Collaborator
LeonarddeR
left a comment
There was a problem hiding this comment.
Works properly in Thunderbird for me as well.
michaelDCurran
approved these changes
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #13109
Summary of the issue:
Thunderbird and Firefox were broken with PR #13096.
Description of how this pull request fixes the issue:
RelationTypeenum now also inherits fromstr, its values can now be used as a string value.strtypes toRelationTypeTesting strategy:
Known issues with pull request:
None
Change log entries:
None
Code Review Checklist: