Skip to content

Fix Enum str mixup#13112

Merged
feerrenrut merged 2 commits intomasterfrom
fixEnumStrMixup
Dec 2, 2021
Merged

Fix Enum str mixup#13112
feerrenrut merged 2 commits intomasterfrom
fixEnumStrMixup

Conversation

@feerrenrut
Copy link
Copy Markdown
Contributor

Link to issue number:

fixes #13109

Summary of the issue:

Thunderbird and Firefox were broken with PR #13096.

Description of how this pull request fixes the issue:

  • The RelationType enum now also inherits from str, its values can now be used as a string value.
  • Fixed conversion of plain str types to RelationType
  • Introduced a faster approach to get relation targets of the relation type.

Testing strategy:

  • Tested locally with Firefox.
  • Ask reporters to verify fix.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@feerrenrut feerrenrut marked this pull request as ready for review December 1, 2021 09:38
@feerrenrut feerrenrut requested a review from a team as a code owner December 1, 2021 09:38
@feerrenrut
Copy link
Copy Markdown
Contributor Author

One reporter has verified the PR resolves the issue.

@tapper82
Copy link
Copy Markdown

tapper82 commented Dec 1, 2021

Tested in firefox 95 64 bit and Thunderbird Daily 96.0a1 (2021-11-30) (64-bit) Running on windows 11 64 bit.

Copy link
Copy Markdown
Collaborator

@OzancanKaratas OzancanKaratas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your work!

Copy link
Copy Markdown
Collaborator

@LeonarddeR LeonarddeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works properly in Thunderbird for me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA broken with firefox

6 participants