Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show IAccessible2 relations in developer info #13315

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

LeonarddeR
Copy link
Collaborator

@LeonarddeR LeonarddeR commented Feb 8, 2022

Link to issue number:

None

Summary of the issue:

IAccessible2 has a concept of relations between objects. Among other things, this is used for aria-details, aria-controls, etc.

Description of how this pull request fixes the issue:

Show the relations for an object in the developer info for ease of debugging. Note that this only shows the relations, not the objects itself.

Testing strategy:

Used the example from https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls to prove that the relations shown in code are also visible in the developer info with this patch applied.

Known issues with pull request:

None known

Change log entries:

For Developers

  • IAccessible2 relations are now shown in developer info for IAccessible2 objects.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@LeonarddeR LeonarddeR requested a review from a team as a code owner February 8, 2022 06:38
@AppVeyorBot
Copy link

See test results for failed build of commit bc1b962b57

@LeonarddeR
Copy link
Collaborator Author

Note that the system tests are not related.

Copy link
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonarddeR

@seanbudd
Copy link
Member

seanbudd commented Feb 9, 2022

I will look at merging once #13320 is merged

@seanbudd seanbudd merged commit 99ef824 into nvaccess:master Feb 9, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants