Restore explicit value definitions for control types states and roles#13603
Merged
Conversation
michaelDCurran
previously approved these changes
Apr 12, 2022
Explicit values were replaced with auto defined values in commit d4586a5 however some add-ons still depend on the values used. For now, the values have been restored.
feerrenrut
force-pushed
the
controlTypesValues
branch
from
30c4b26 to
6f9dbba
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Backport the exceptions for labels change from master.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, related to #13588
Based on conversation in https://nvda-addons.groups.io/g/nvda-addons/topic/90329930
Summary of the issue:
Some add-ons depend on the legacy values of
controlTypes.Roles(and possiblycontrolTypes.States)These were removed in commit d4586a5 via PR #13414.
Description of how this pull request fixes the issue:
Restore the values using more developer friendly definitions, use unit tests to ensure values match and can be constructed from and compared with integer values, or constructed from the enum value name.
Testing strategy:
None
Known issues with pull request:
None
Change log entries:
For Developers:
Changes to existing entry, see diff.
Code Review Checklist: