Skip to content

appModules/calculator: focus.appModule.productVersion -> self.productVersion#13696

Merged
seanbudd merged 1 commit intonvaccess:masterfrom
josephsl:w10calculatorProductVersion
May 16, 2022
Merged

appModules/calculator: focus.appModule.productVersion -> self.productVersion#13696
seanbudd merged 1 commit intonvaccess:masterfrom
josephsl:w10calculatorProductVersion

Conversation

@josephsl
Copy link
Copy Markdown
Contributor

Hi,

Forgot to do this while fixing #13386

Link to issue number:

Follow-up to #13383

Summary of the issue:

Cosmetics: focus.appModule.productVersion -> self.productVersion for consistency.

Description of how this pull request fixes the issue:

Changes focus.appModule.productVersion to self.productVersion in Calculator results script. No changes to functionality whatsoever.

Testing strategy:

Manual testing, see #13383.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@josephsl josephsl requested a review from a team as a code owner May 14, 2022 15:19
@josephsl josephsl requested a review from seanbudd May 14, 2022 15:19
@seanbudd seanbudd merged commit 375e49a into nvaccess:master May 16, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone May 16, 2022
@josephsl josephsl deleted the w10calculatorProductVersion branch May 19, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants