Merge beta to rc for 2022.1rc2#13709
Merged
Merged
Conversation
Closes part of #13679 Summary of the issue: It appears that when resetting a config, the seika notetaker driver can be terminated before it has been initialized. Description of how this pull request fixes the issue: Only terminate the notetaker driver if it has been initialized. Known issues with pull request: Another issue is highlighted in #13679. While terminating/initializing during a config change, the braille.handler is attempted to be used when handling events on NVDA objects. This is a more complex problem and needs a braille device to reproduce and test.
Fixes #13694 Summary of the issue: NVDA start up is slow. Speech is announced during start up to warn the user that start up is slow. If using SAPI5 and audioducking is enabled, SAPI5 will try to duck the audio using wx callbacks The wxWidgets App has not beeing initialized, so the callback fails and NVDA crashes. Description of how this pull request fixes the issue: Throw a known exception if NVDA is not ready when callLater is called. If this exception occurs when audio ducking, force audio ducking to unduck immediately instead of delay Testing strategy: Manual testing: Using NVDA 2022.1rc1 with audio ducking enabled and SAPI5. emulate a slow start up and reproduce the crash. Using a try build from this PR with audio ducking enabled and SAPI5. emulate a slow start up. Note that the warning message that announces that NVDA start up is slow doesn't duck audio Note that NVDA starts successfully Confirm that audio ducking works as expected once NVDA has started Note the following log WARNING - mathPres.initialize (12:46:35.192) - MainThread (6344): MathPlayer 4 not available DEBUGWARNING - core.main (12:46:40.207) - MainThread (6344): Slow starting core (6.88 sec) IO - speech.speech.speak (12:46:40.207) - MainThread (6344): Speaking [LangChangeCommand ('en_US'), 'Loading NVDA. Please wait...'] DEBUGWARNING - characterProcessing._getSpeechSymbolsForLocale (12:46:40.208) - MainThread (6344): No CLDR data for locale en_US DEBUGWARNING - synthDrivers.sapi5.SynthDriver.speak (12:46:40.344) - MainThread (6344): Unsupported speech command: LangChangeCommand ('en_US') DEBUGWARNING - audioDucking._unensureDucked (12:46:40.349) - MainThread (6344): wx App not initialized, cannot delay audio un-duck INFO - core.main (12:46:40.349) - MainThread (6344): Using wx version 4.1.1 msw (phoenix) wxWidgets 3.1.5 with six version 1.16.0
From translation svn revision: 67680 Authors: Ali Ustek <aliustek@gmail.com> Patrick Galasso <Patrice.galasso@gmail.com> Jwanro Mustafa <jwanroabdula@hotmail.com> Kosrat D Ahmad <kosrat.d.ahmad@gmail.com> silva.hm88@gmail.com Stats: 560 465 source/locale/ckb/LC_MESSAGES/nvda.po 1 file changed, 560 insertions(+), 465 deletions(-)
From translation svn revision: 67680 Authors: Bram Duvigneau <bram@bramd.nl> Bart Simons <bart@bartsimons.be> A Campen <a.campen@wxs.nl> Leonard de Ruijter <alderuijter@gmail.com> Stats: 1 1 source/locale/nl/LC_MESSAGES/nvda.po 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 67680 Authors: Dinakar T.D. <td.dinkar@gmail.com> Stats: 1 1 user_docs/ta/userGuide.t2t 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 67680
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must be a merge commit not a squash merge
Fixes included:
New translations are being incorporated in 2022.1rc2, notably: