Skip to content

Update braille when tethered to review but review cursor does not follow caret #15134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
burmancomp wants to merge 7 commits into from
Closed

Update braille when tethered to review but review cursor does not follow caret #15134

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
81fda2a
update braille when tethered to review but review does not follow caret
burmancomp Jul 11, 2023
18a5da4
Merge branch 'master' into updateBrailleWhenTetheredToReviewButReview…
burmancomp Jul 12, 2023
2afd12c
minor modifications
burmancomp Jul 12, 2023
2e583ab
Merge branch 'master' into updateBrailleWhenTetheredToReviewButReview…
burmancomp Jul 12, 2023
5bb11ec
logic moved to braille module
burmancomp Jul 12, 2023
23b6698
indentation fix
burmancomp Jul 12, 2023
81dcab0
suggested changes
burmancomp Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/braille.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2468,6 +2468,12 @@ def handleCaretMove(
if shouldAutoTether:
self.setTether(TetherTo.FOCUS.value, auto=True)
if self._tether != TetherTo.FOCUS.value:
# Braille display content is updated in case where:
# braille is tethered to review, review cursor does not follow system caret,
# and focus object is navigator object.
if not config.conf["reviewCursor"]["followCaret"]:
if obj == api.getNavigatorObject():
self.handleUpdate(obj)
return
region = self.mainBuffer.regions[-1] if self.mainBuffer.regions else None
if region and region.obj==obj:
Expand Down