Conversation
Fixup of #15472 Summary of the issue: A default gesture to open the new audio panel is desirable Description of user facing changes Adds nvda+ctrl+u as a command to open the audio panel Commands for opening settings panels are now included in the key commands doc Description of development approach Adds nvda+ctrl+u as a command to open the audio panel Adds keyCommands to the appveyor build for easier review of changes. Updates to user guide
Link to issue number: Partially reverts #15472. Summary of the issue: The "output device" option has been removed from the NVDA+Control+s dialog. This breaks muscle memory for long-time NVDA users and makes it very hard to blindly (without audible speech or connected Braille) change sound devices in the event of unexpected device switching. Description of how this pull request fixes the issue: Selectively reverts the change in #15472 that removes the option from the synth selection dialog. Testing strategy: Verified that the "output device" option in both dialogs works as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.