App module handler: remove Windows 8 check from product info and store app checks#15641
Merged
seanbudd merged 2 commits intoOct 18, 2023
Merged
Conversation
…and version. Re nvaccess#15637. As Windows 8.1 is the minimum supported OS, there is no need to check for Windows 8.0 when fetching product name and version. However, do keep a comment on converted desktop apps.
…. Re nvaccess#15637. Remove Windows 8 check from isWindowsStoreApp as minimum OS is Windows 8.1.
seanbudd
approved these changes
Oct 18, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #15637
Summary of the issue:
Windows 8 checks are present in app module handler when minimum OS version is 8.1.
Description of user facing changes
None
Description of development approach
Removed Windows 8 check from the following:
Testing strategy:
Manual testing: tested that on Windows 10 and 11, both desktop and universal (Store) apps return the correct version even with Windows 8 check removed.
Known issues with pull request:
None
Code Review Checklist: