Do not offer External channel in tabs where it is not relevant

[CyrilleB79]

Link to issue number:

Closes #15039

Summary of the issue:

External appears in channel filter list even in tabs where it is not relevant, i.e. in Available add-ons and Updatable add-ons.

Description of user facing changes

Remove these External channel from the channel filter list in these tabs.

Description of development approach

See code.

Testing strategy:

Manual testing.

Known issues with pull request:

None

Change log

None for such a small fix.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• FAIL: Lint check. See test results for more information.
• PASS: System tests (tags: installer NVDA).
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/tu6dnucmmof0a4o2/artifacts/output/nvda_snapshot_pr15702-29776,b8b41c71.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 24.9,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 7.9,
  FINISH_END 0.1

See test results for failed build of commit b8b41c7163

[lukaszgo1]

External appears in channel filter list even in tabs where it is not relevant, i.e. in Available add-ons and Updatable add-ons.

Why you consider 'external' to be irrelevant in the 'updateable' tab? As far as I can tell add-ons in that tab can be either installed from the store, or installed from the add-on bundle, but with a more recent version present in the store.

[CyrilleB79]

Why you consider 'external' to be irrelevant in the 'updateable' tab? As far as I can tell add-ons in that tab can be either installed from the store, or installed from the add-on bundle, but with a more recent version present in the store.

*Because the channel visible in the Updatable add-ons tab is not the channel of the installed add-on but the channel through which a new version can be offered from the store.

E.g. say you have installed Speech logger 23.3.08 externally. Checking the updatable add-ons:

• if you select stable channel, you are offered the stable version from the store, i.e. 23.3.09
• if you select dev channel, you are offered the dev version from the store, i.e. 23.3.109 sélectionné
• if you select external channel, you are not offered anything since the store does not offer anything through external channel by definition

To summarize, the column "Channel" in this tab should be understood as "Available channel", not as "Installed channel".

[seanbudd]

Thanks @CyrilleB79