Suppress garbageHandler log warnings#15778
Merged
Conversation
Contributor
|
@seanbudd, please also update the documentation, i.e. projectDocs/design/unreachableObjects.md. |
lukaszgo1
reviewed
Nov 18, 2023
| log.error(f"Found at least {_reportCountDuringCollection} unreachable objects in run") | ||
| log.debugWarning(f"Found at least {_reportCountDuringCollection} unreachable objects in run") | ||
| else: | ||
| log.error(f"Unknown action: {action}") |
Contributor
There was a problem hiding this comment.
Shouldn't this remain logged at error level, so that if there are any additions to the actions supported by Python's gc interface, we are warned in advance?
seanbudd
added
the
conceptApproved
michaelDCurran
approved these changes
Nov 22, 2023
|
I think this PR also addresses #15356, so that can probably be closed too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15634
Summary of the issue:
The information provided by garbageHandler is very noisy, and not indicative of a high priority fatal error.
Description of user facing changes
Less noisy logs, and less frequent error bells on dev builds of NVDA.
Description of development approach
Instead of logging every object on deletion, only log the number of objects deleted at "warning" level.
Logging every object can be enabled by enabling debug logging for garbageHandler.
Testing strategy:
Manual testing
Known issues with pull request:
Code Review Checklist: