Skip to content

Log NVDA app architecture at startup#16528

Merged
seanbudd merged 5 commits into
nvaccess:masterfrom
josephsl:i16432logNVDAArch
May 13, 2024
Merged

Log NVDA app architecture at startup#16528
seanbudd merged 5 commits into
nvaccess:masterfrom
josephsl:i16432logNVDAArch

Conversation

@josephsl
Copy link
Copy Markdown
Contributor

Link to issue number:

Closes #16432

Summary of the issue:

NVDA does not log its own app architecture at startup.

Description of user facing changes

NVDA's app architecture will be logged as part of the log at startup.

Description of development approach

At startup, log os.environ["PROCESSOR_ARCHITECTURE"], useful if running NVDA on 64-bit systems and to prepare for #16304 work.

Testing strategy:

Manual testing: compare log output between before (prior to this PRE) and after (merging this PR).

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

josephsl added 4 commits May 12, 2024 14:06
Python code modernization: use formatted string liters (f strings) when reporting version info at startup.
Report NVDA app architecture (x86 only as of this commit) at startup - effectively recording Python architecture.
@josephsl josephsl requested a review from a team as a code owner May 12, 2024 21:09
@josephsl josephsl requested a review from SaschaCowley May 12, 2024 21:09
@seanbudd seanbudd merged commit 33fab4f into nvaccess:master May 13, 2024
@josephsl josephsl deleted the i16432logNVDAArch branch May 13, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NVDA version info: log Python/NVDA architecture as part of version information

2 participants