Log NVDA app architecture at startup#16528
Merged
Merged
Conversation
Python code modernization: use formatted string liters (f strings) when reporting version info at startup.
Report NVDA app architecture (x86 only as of this commit) at startup - effectively recording Python architecture.
seanbudd
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #16432
Summary of the issue:
NVDA does not log its own app architecture at startup.
Description of user facing changes
NVDA's app architecture will be logged as part of the log at startup.
Description of development approach
At startup, log os.environ["PROCESSOR_ARCHITECTURE"], useful if running NVDA on 64-bit systems and to prepare for #16304 work.
Testing strategy:
Manual testing: compare log output between before (prior to this PRE) and after (merging this PR).
Known issues with pull request:
None
Code Review Checklist: