Conversation
|
Ugh, I now realize that having #16868 run |
|
@LeonarddeR - I think we will have the same problem for scons checkPot too, I imagine we need to set up visual studio build tools before we can run these checks. I think we will have to exclude checkPot, and scons source for now. Perhaps also unit tests. |
seanbudd
added
the
conceptApproved
seanbudd
force-pushed
the
applyPreCommit
branch
from
ed3fa74 to
3a0f237
Compare
seanbudd
changed the title
WalkthroughThe recent updates enhance the NVDA project's development workflow by introducing a Continuous Integration (CI) configuration in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
projectDocs/dev/contributing.md (1)
47-47: Consider adding a comma for clarity.A comma would improve the readability of the sentence.
- [Template guide](./githubPullRequestTemplateExplanationAndExamples.md),Tools
LanguageTool
[typographical] ~47-~47: Consider adding a comma here.
Context: ...ng out the template: - Template guide - Please fill out the Pull Request template, inc...(PLEASE_COMMA)
This reverts commit 53003dc.
…o applyPreCommit
| autoupdate_commit_msg: "Pre-commit autoupdate" | ||
| autofix_commit_msg: "Pre-commit autofix" |
There was a problem hiding this comment.
| autoupdate_commit_msg: "Pre-commit autoupdate" | |
| autofix_commit_msg: "Pre-commit autofix" | |
| autoupdate_commit_msg: "Pre-commit automatic update" | |
| autofix_commit_msg: "Pre-commit automatic fix" |
There was a problem hiding this comment.
Could you open a small PR to fix this up. Maybe auto-fix and auto-update instead?
| hooks: | ||
| # Checks python syntax | ||
| - id: check-ast | ||
| # File uses encoding not supported in Linux |
There was a problem hiding this comment.
Ugh, I actually believe that comtypes should consider to fix this, enforcing UTF-8 for their generated modules. I filed enthought/comtypes#592
There was a problem hiding this comment.
Perhaps we should also consider adding encoding checks to pre-commit?
|
Oops, too late 😉 |
3 participants
Link to issue number:
Part of #10516
Summary of the issue:
As a developer, I would like automation tools to fix the lint of my code when I open a PR.
After #16936, we have applied pre-commit on all files. However, there are no automation checks for some of these checks (like whitespaces changes). Which means without running pre-commit automatically, the repository may have pre-commit regressions.
Description of user facing changes
Improved documentation for pre-commit hooks and the PR contribution process.
Description of development approach
Setup Pre-commit CI. This is a CI/CD tool to automatically apply pre-commit to PRs.
Testing strategy:
Confirm build succeeds.
Ensure failures from AppVeyor (e.g lint failures) are caught by pre-commit.
Known issues with pull request:
None
Code Review Checklist:
Summary by CodeRabbit
New Features
Documentation