Fix failing browsable messages#16942
Conversation
WalkthroughThe recent changes enhance NVDA's functionality by introducing improved handling of the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
cc @CyrilleB79
Link to issue number:
Fixes #16806
Summary of the issue:
Opening browsable messages can sometimes fail. The underlying issue is that this requires a COM Interface wrapper that is not bundled with NVDA. It will therefore be created on the fly and stored in
%temp%\comtypes_cache\nvda-311Description of user facing changes
No crashes, no creation of these modules in temp folder.
Description of development approach
Added the interface definition to
comInterfaces_sconscriptTesting strategy:
.venv\Lib\site-packages\comtypes\genwon't be populated withScripting.pyand_420B2830_E718_11CF_893D_00A0C9054228_0_1_0.py%temp%\comtypes_cache\nvda-311won't be populated withScripting.pyand_420B2830_E718_11CF_893D_00A0C9054228_0_1_0.pyKnown issues with pull request:
None
Code Review Checklist:
Summary by CodeRabbit
New Features
Scripting.pyinterface, enhancing COM interaction capabilities.Bug Fixes
Documentation