Merged
Conversation
Fixes #17344 Summary of the issue: The SpeechSymbols only sets the filename to write to when the dictionary is loaded. Before 826ef91, dictionary files were always loaded before they were saved. Afterwards, dictionaries are saved without being loaded. When trying to save dictionary files the following error occurs, due to no file name being set Speaking [LangChangeCommand ('en_US'), 'pressed'] ERROR - unhandled exception (17:00:20.842) - MainThread (9964): Traceback (most recent call last): File "gui\settingsDialogs.pyc", line 5350, in onOk File "characterProcessing.pyc", line 364, in save ValueError: No file name Description of user facing changes Users can now save the speech dictionary dialog. Add-ons which use custom speech dictionaries are also saved correctly now. Description of development approach Create optional parameter to set filename path for speech dictionaries.
Provide speech symbols file name path on creation (#17346)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.