Refined Chinese character descriptions and added entries for ancient characters and tongjiazi (phonetic loan characters).#17727
Merged
Conversation
…characters and tongjiazi (phonetic loan characters).
Contributor
Author
|
The simplified Chinese character descriptions are mainly maintained by Alan and I hope to mention his contributions here. Many Thanks, cc @Alan86024 |
seanbudd
added
the
conceptApproved
hwf1324
reviewed
Feb 27, 2025
| @@ -8028,7 +8052,8 @@ z Zulu 第26个字母 | |||
| 餯 (餯：饭馊臭) | |||
| 鰴 (鰴鲸的鰴) 力大的鱼。 | |||
| 㑰 (㑰：【字彙】古無此字。見楊升庵集。義與𣨶同。【正字通】楊集本作𤸁，𤸁𣨶音義同。譌作㑰，非。) | |||
| 㑹 (㑹：拼音：huì，部首：人，笔顺：341251212511) | |||
| 㤬 | |||
Contributor
There was a problem hiding this comment.
This line causes a parsing error
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Mar 5, 2025
This is the follow-up to #17727 Summary of the issue: Fixed some entries that caused parsing error. Deleted duplicate entries Description of user facing changes No parsing error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
For Chinese, the characterDescriptions.dic file has been updated to refine existing descriptions and add more entries for ancient characters and tongjiazi (phonetic loan characters).
Description of user facing changes
The Chinese character description has been updated to provide more Chinese character descriptions.
Description of development approach
The characterDescriptions.dic file has been updated to refine existing descriptions and add more entries for ancient characters and tongjiazi (phonetic loan characters).
Testing strategy:
Manual testing
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary