Revert Applications Volume Adjuster

[seanbudd]

Reverts PR

Reverts #17271
Reverts #16591
Reverts #17634

Issues fixed

Fixes #17654
Fixes #17882
Fixes #17124
Fixes #17656

Issues reopened

Reopens #16052

Reason for revert

• Exception in on_session_created when windows sound is played after replugging output device #17654: The applications volume adjust feature is affecting Windows sound output even if the feature is disabled.
• NVDA does not announce when application volume control feature is toggled using assigned gesture #17882: bug: NVDA does not announce when application volume control feature is toggled using assigned gesture
• Application volume adjuster: make the setting profile independent #17124: unclear UX in regards to if the settings should be profile independent
• NVDA Alpha: NVDA does not control the volume of applications that uses an audio output device other than Windows default device. #17656: NVDA doesn't control the volume of applications which use non-default windows output

Can this PR be reimplemented? If so, what is required for the next attempt

• Refer to debug suggestions in Exception in on_session_created when windows sound is played after replugging output device #17654 (comment)
• Ensure Application volume adjuster: make the setting profile independent #17124 is considered in the next attempt
• See Fix-up of the toggle apps volume control command #17885 for fix for NVDA does not announce when application volume control feature is toggled using assigned gesture #17882
• NVDA Alpha: NVDA does not control the volume of applications that uses an audio output device other than Windows default device. #17656 should at least be documented, if not resolved

[seanbudd]

cc @CyrilleB79 @mltony @LeonarddeR @ABuffEr @codeofdusk: as those who contributed to this issue/feature discussion

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: License check.
• PASS: Unit tests.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/ka8r7qstniq923hs/artifacts/output/nvda_snapshot_pr17886-35842,4ca4596e.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.2,
  INSTALL_END 1.0,
  BUILD_START 0.0,
  BUILD_END 17.7,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 1.0,
  FINISH_END 0.1

See test results for failed build of commit 4ca4596eb2

[LeonarddeR]

While it is a pity that this is reverted for those who really like this feature, I think this is the right decision.
That said, do the reverted prs contain any fixes for features that are intertwined, such as sound split? Those should be considered if any.
For example, #16591 states:

I refactored sound split code...

[seanbudd]

@LeonarddeR - we are not aware of any explicit known fixes for sound split from this PR, no associated logged issues were mentioned in the PR.

[seanbudd]

I'd also mention that it is fairly possible/likely the bug #17654 was introduced via the refactoring, not necessarily from the feature itself

[beqabeqa473]

i don't think soundsplit as well as application volume adjuster need to be in nvda core. They can greatly fit in addon.
NVDA is primarily a screenreader, and if user needs such functionality, they can easily install an addon.

I recall discussion when nvaccess was strongly against including systraylist addon into core, but i am sure that feature more likely is direct screenreader feature rather than these features, which simply overload application.
I think NVaccess philosophy should be as it was earlier, include in the core features, which are directly related to screenreader.

[CyrilleB79]

I am one of the ones who would have loved this feature to be integrated in core. But unfortunately, the feature as implemented in last alpha was not robust enough. This revert PR fixes #17654 so that's the way to go.

@beqabeqa473 The integration of the feature in NVDA core has been accepted (triaged) by NV Access.

1. That's not the place at all to question this decision. Feature request: add command to adjust volume of all applications except for NVDA #16052 is being reopened and this would be a better place to discuss this.
2. There has already been a very long discussion before the feature was integrated. If you really want to question this triage decision, please be sure to provide new arguments that may really give a chance for the decision to be reconsidered.
3. Sound split remains in NVDA's core and has already done its path to stable releases. If you really wish to remove it from core, please open a dedicated issue with a strong argumentation: I do not even know if a feature has ever been removed from stable releases.

[HBM2001]

Hello everyone, to be honest, I THINK the sound split feature may also be necessary in certain cases, such as checking the position of a headset or speaker.
Regarding the application's volume control feature, I'm not entirely sure whether it is necessary, some addons already provide this functionality

[SaschaCowley]

@LeonarddeR IIRC when I tried to track down the commit that introduced #17654 the earliest commit I could track it to was the refactor of sound split. It's also not present in 2024.4.2.