Skip to content

Don't send send keys gesture if not connected#17927

Merged
seanbudd merged 3 commits intobetafrom
fixToggleControl
Apr 10, 2025
Merged

Don't send send keys gesture if not connected#17927
seanbudd merged 3 commits intobetafrom
fixToggleControl

Conversation

@SaschaCowley
Copy link
Copy Markdown
Member

@SaschaCowley SaschaCowley commented Apr 10, 2025

Link to issue number:

Fixes #17874

Summary of the issue:

Performing the "Toggle Control" gesture (NVDA+alt+tab) when no Remote Access session is in progress results in the gesture being sent to the operating system.

Description of user facing changes

The gesture is always trapped by NVDA.

Description of development approach

In remoteClient.client.RemoteClient.toggleRemoteKeyControl, no longer call gesture.send if there is no leader session. Also inform the user if not connected, if not connected as leader, or if there are no followers connected.

Testing strategy:

Performed the gesture:

  • When not connected
  • When connected as follower with no one else in the channel
  • When connected as follower with a remote leader in the channel
  • When connected as follower with a remote follower in the channel
  • When connected as leader with no one else in the channel
  • When connected as leader with a remote leader in the channel
  • When connected as leader with a remote follower in the channel

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley marked this pull request as ready for review April 10, 2025 03:50
@SaschaCowley SaschaCowley requested a review from a team as a code owner April 10, 2025 03:50
@SaschaCowley SaschaCowley requested a review from seanbudd April 10, 2025 03:50
Comment thread source/remoteClient/client.py Outdated
@seanbudd seanbudd merged commit ae31e6c into beta Apr 10, 2025
3 of 4 checks passed
@seanbudd seanbudd deleted the fixToggleControl branch April 10, 2025 05:39
@github-actions github-actions bot added this to the 2025.2 milestone Apr 10, 2025
@seanbudd seanbudd modified the milestones: 2025.2, 2025.1 Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants