Skip to content

Comments

Fix redundant table end markers in tables in Word with UIA enabled#17938

Merged
seanbudd merged 2 commits intonvaccess:masterfrom
LeonarddeR:uiaFix
Apr 11, 2025
Merged

Fix redundant table end markers in tables in Word with UIA enabled#17938
seanbudd merged 2 commits intonvaccess:masterfrom
LeonarddeR:uiaFix

Conversation

@LeonarddeR
Copy link
Collaborator

Link to issue number:

Fixes #15828

Summary of the issue:

When UIA is enabled in word and the cursor is halfway a table cell, NVDA will braille table end ath the cursor position.

Description of user facing changes

Table end will no longer be shown.

Description of development approach

In cases where this happens, it looks like there are at leass two findings.

  1. textRange.CompareEndpoints returns a huge number (always 6029412 in my case)
  2. It does so regardless where comparing start to start, end to end
  3. This also means that the number of the end to end comparison is positive, basically meaning that the end of the inner range is greater than the end of the outer range. This should be impossible anyway.

Testing strategy:

Tested str from #15828

Known issues with pull request:

  • I'm afraid that in these broken cases, we will miss the table end marker in braille. I'd rather miss it than having it redundantly though.
  • This does not fix the issue in Teams @dkager mentioned. I'll open a new issue for that.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@LeonarddeR LeonarddeR requested a review from a team as a code owner April 10, 2025 17:28
@AppVeyorBot
Copy link

See test results for failed build of commit b7e31d0f87

@seanbudd seanbudd merged commit 8a234e2 into nvaccess:master Apr 11, 2025
3 of 5 checks passed
@github-actions github-actions bot added this to the 2025.2 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect table end markers in Word 365

4 participants