Move crowdin sync and mozilla symbols from the legacy deploy script (which never runs) to pushPackagingInfo at end of build.#17955
Merged
Merged
Conversation
…which never runs) to pushPackagingInfo at end of build.
seanbudd
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
Crowdin is not getting the latest source strings for nvda.pot.
When we moved to the new deploy webhook on the new NV Access Infrastructure, there was an assumption that the old deploy script would still run. This is not the case. If a deploy section is specified, deploy_script does not run. There were some extra actions in the old deploy script such as uploading to Crowdin and the Mozilla symbol server, but as the old deploy script no longer runs, these actions do not occur.
Description of user facing changes
None.
Description of development approach
Moved upload to Crowdin and Mozilla Symbol Server from the old deployScript.ps1 and into pushPackagingInfo.ps1, which always runs in on_finish.
Testing strategy:
Can only test live by watching a new beta build.
Known issues with pull request:
None known.
Code Review Checklist:
@coderabbitai summary