Skip to content

Move crowdin sync and mozilla symbols from the legacy deploy script (which never runs) to pushPackagingInfo at end of build.#17955

Merged
seanbudd merged 1 commit into
betafrom
noLegacyDeploy
Apr 14, 2025
Merged

Move crowdin sync and mozilla symbols from the legacy deploy script (which never runs) to pushPackagingInfo at end of build.#17955
seanbudd merged 1 commit into
betafrom
noLegacyDeploy

Conversation

@michaelDCurran
Copy link
Copy Markdown
Member

Link to issue number:

None.

Summary of the issue:

Crowdin is not getting the latest source strings for nvda.pot.
When we moved to the new deploy webhook on the new NV Access Infrastructure, there was an assumption that the old deploy script would still run. This is not the case. If a deploy section is specified, deploy_script does not run. There were some extra actions in the old deploy script such as uploading to Crowdin and the Mozilla symbol server, but as the old deploy script no longer runs, these actions do not occur.

Description of user facing changes

None.

Description of development approach

Moved upload to Crowdin and Mozilla Symbol Server from the old deployScript.ps1 and into pushPackagingInfo.ps1, which always runs in on_finish.

Testing strategy:

Can only test live by watching a new beta build.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

…which never runs) to pushPackagingInfo at end of build.
@michaelDCurran michaelDCurran requested a review from a team as a code owner April 14, 2025 04:01
@michaelDCurran michaelDCurran requested a review from seanbudd April 14, 2025 04:01
@seanbudd seanbudd merged commit 8c216f6 into beta Apr 14, 2025
4 of 5 checks passed
@seanbudd seanbudd deleted the noLegacyDeploy branch April 14, 2025 04:07
@github-actions github-actions Bot added this to the 2025.2 milestone Apr 14, 2025
@seanbudd seanbudd modified the milestones: 2025.2, 2025.1 Apr 14, 2025
@seanbudd seanbudd mentioned this pull request Apr 14, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants