Merged
Conversation
Member
SaschaCowley
commented
May 2, 2025
SaschaCowley
commented
- Merge pull request Updated the symbols, gestures, character descriptions files for Simplified Chinese #17958 from nvdacn/PullRequestToNVDA
- Improve focus handling in the Remote Access Connection dialog (Improve focus handling in the Remote Access Connection dialog #18031)
- Don't toggle mute when not connected (Don't toggle mute when not connected #18032)
Description of user facing changes Updated the symbols, gestures, character descriptions files for Simplified Chinese. Description of development approach Updated the symbols, gestures, character descriptions files for Simplified Chinese.
Closes #17973 Summary of the issue: Focus handling in the "Connect to another computer" dialog is suboptimal. Description of user facing changes * When connecting using a remote relay server, after a key is generated by the server, the key field is automatically focused. * When connecting using a local relay server, after detecting the external IP, the external IP field is automatically focused. * When attempting to initiate a connection with a blank host/port and/or key field, the first erroneously empty field is focused after the error dialog is dismissed. Description of development approach Focusing key/external IP fields: Since the indeterminate progress dialog is shown asynchronously, we can't know for certain when the connection dialog will be focusable again. This is problematic as we can only (successfully) call `SetFocus` on children of focusable dialogs. To work around this, bind an event handler to the dialog after successfully generating a key/detecting the external IP that: * Is triggered by `wx.EVT_ACTIVATE`, so it fires when the dialog is focused (as this only happens when the dialog is focusable). * Focuses the key or external IP field, as appropriate. * Unbinds itself, so the event is only called the once. Focusing the first empty control: Add an `if` statement that selects the appropriate control based on which one is empty. Testing strategy: Attempted to perform a variety of legal and illegal operations with the dialog. Known issues with pull request: None.
Fixes #17985 Summary of the issue: Muting remote via an input gesture works even if no remote access session is in progress. Description of user facing changes Using an input gesture to mute Remote Access is now disallowed when not connected. Description of development approach Check whether connected in `_remoteClient.client.RemoteClient.toggleMute`. Testing strategy: Tested muting and unmuting when connected and not connected. Known issues with pull request: Muting is still allowed when connected as follower, which doesn't seem to make sense. See #18039.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.