Merged
Conversation
Fixes #18039 Summary of the issue: The mute and send SAS items are available in the Remote Access submenu even when connected as a follower. Description of user facing changes These options are only shown when connected as a leader. Description of development approach In `_remoteClient.menu.Menu.handleConnected`, only enable the mute and send SAS menu items if connected and connection mode is leader. In `_remoteClient.client.RemoteClient`, updated the `toggleMute` and `sendSAS` methods to report failure and return early when not connected as leader. Updated unit tests to work with the new checks. Testing strategy: Manually tested that the items are unavailable in the given situations. Unit tests. Known issues with pull request: None.
Fixes #17944 Summary of the issue: * The description of "This action cannot be undone." in "Delete all trusted fingerprints" is inaccurate and can be easily restored by pressing NVDA+Ctrl+R. * The Remote Access section in the user guide is fairly repetitive, in particular the Setting Up a Remote Access session, and the Remote Access Dialog section. Note that #17944 also mentions two problems which from my reading seem to already be addressed by previous PRs: 1. The usage of "Allow this machine to be controlled", "Control another machine", "Relay Server", "Direct Connection" is outdated. 2. "You can assign further commands in the Remote section of the Input Gestures dialog." This sentence should be adjusted appropriately to emphasize assigning shortcut keys to commands that have not assigned keys. Description of user facing changes * Remote access settings - delete fingerprints: remove note that this action cannot be undone from both the warning dialog and the user guide, as reverting NVDA's config will restore these. * Remote access Getting Started section in user guide: again remind the user that enable remote access needs to be checked before the Remote Access menu in the Tools menu will be available. * userguide: rewrite the Setting Up a Remote Access Session, merging the Remote Access Dialog section directly into it, removing repetitiveness. Description of development approach n/a Testing strategy: n/a Known issues with pull request: None known.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.