Remove the option for Remote Access to play beeps #18100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18087
Summary of the issue:
Remote Access currently has the option to choose between sounds and beeps for audio cues. This is extra code that we have to maintain, and is not an option that is present elsewhere in NVDA.
Description of user facing changes
The option has been removed. Remote Access will only play audio cues.
Description of development approach
gui.settingsDialogs.RemoteSettingsPanel, removed the checkbox and references thereto that controlled this setting._remoteClient.cues, removed the code that playes beep sequences from_playCue, includingshouldPlaySounds, as this is now alwaysTrue. Removed eachbeepsfield from the various cues, and edited the type definition ofCueto no longer include this field.tones, removedbeepSequence,beepSequenceAsync, and associated datatypes and imports.playSoundsoption from the config spec, and the rename from theupgradeConfigFrom_16_to_17function.Testing strategy:
Known issues with pull request:
None known
Code Review Checklist:
@coderabbitai summary