Skip to content

Conversation

@SaschaCowley
Copy link
Member

@SaschaCowley SaschaCowley commented May 14, 2025

Link to issue number:

Closes #18087 

Summary of the issue:

Remote Access currently has the option to choose between sounds and beeps for audio cues. This is extra code that we have to maintain, and is not an option that is present elsewhere in NVDA.

Description of user facing changes

The option has been removed. Remote Access will only play audio cues.

Description of development approach

  1. In gui.settingsDialogs.RemoteSettingsPanel, removed the checkbox and references thereto that controlled this setting.
  2. In _remoteClient.cues, removed the code that playes beep sequences from _playCue, including shouldPlaySounds, as this is now always True. Removed each beeps field from the various cues, and edited the type definition of Cue to no longer include this field.
  3. In tones, removed beepSequence, beepSequenceAsync, and associated datatypes and imports.
  4. Remove the playSounds option from the config spec, and the rename from the upgradeConfigFrom_16_to_17 function.
  5. Edit the user guide to no longer refer to the "Play sounds instead of beeps" option.

Testing strategy:

  1. Tested opening, closing, and saving the Remote Access settings to ensure that they still work as expected.
  2. Started a Remote Access session, and sent the clipboard to make sure various cues still work as expected.
  3. Unit tests.

Known issues with pull request:

None known

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@SaschaCowley SaschaCowley marked this pull request as ready for review May 14, 2025 03:23
@SaschaCowley SaschaCowley requested review from a team as code owners May 14, 2025 03:23
@seanbudd seanbudd added this to the 2025.1 milestone May 14, 2025
@SaschaCowley SaschaCowley merged commit f75f58e into beta May 16, 2025
5 checks passed
@SaschaCowley SaschaCowley deleted the removeRemoteBeeps branch May 16, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants