Skip to content

Don't trigger a different configuration profile when Elements list or find dialogs are opened#18199

Merged
seanbudd merged 2 commits intonvaccess:masterfrom
nvdaes:dontSuspendTriggerProfiles
Jun 2, 2025
Merged

Don't trigger a different configuration profile when Elements list or find dialogs are opened#18199
seanbudd merged 2 commits intonvaccess:masterfrom
nvdaes:dontSuspendTriggerProfiles

Conversation

@nvdaes
Copy link
Collaborator

@nvdaes nvdaes commented May 31, 2025

  • Suspend profile triggers when Element list, and Find dialogs are opened
  • Update changelog

Link to issue number:

Fixes issue #18160.

Summary of the issue:

When the Elements list dialog, or the Find dialog are opened, NVDA may change the configuration profile, instead of using the current profile, for example, a profile created for the web browser. This behavior doesn't match other NVDA's dialogs, where profile triggers are suspended.

Description of user facing changes

NVDA Will use the current profile when Elements list or Find dialogs are opened.

Description of development approach

shouldSuspendConfigProfileTriggers is set to True for Elements list and Find dialogs.

Testing strategy:

  1. Create a configuration profile triggered in Firefox.
  2. Open the Elements list dialog.
  3. Check that Firefox profile is active.
  4. Close the dialog.
  5. Check that Firefox profile is active.
  6. Press Windows+mto go to the desktop.
  7. Check that the normal configuration is active.
  8. Repeat same steps for Find dialog.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@nvdaes nvdaes changed the title dontSuspendTriggerProfiles Don't trigger a different configuration profile when List Element or Find dialogs are opened May 31, 2025
@nvdaes nvdaes changed the title Don't trigger a different configuration profile when List Element or Find dialogs are opened Don't trigger a different configuration profile when Elements list or find dialogs are opened May 31, 2025
@Adriani90
Copy link
Collaborator

Adriani90 commented May 31, 2025

Should this not also apply when opening settings pannel while focusing a an application with an active profile?

@nvdaes
Copy link
Collaborator Author

nvdaes commented May 31, 2025

Adriani wrote: > Should this not also apply when opening settings pannel while focusing a an application with an active profile?

This is the current behavior here:

  1. Create a profile for Firefox.
  2. Press NVDA+control+g (or your shortcut for General settings).
  3. Press NVDA+control+p to check the current profile.
    Here Firefox is the active profile following the above steps, and also opening NVDA's menu and then Preferences, settings.

@nvdaes
Copy link
Collaborator Author

nvdaes commented May 31, 2025

This is a very small pull request. I think that it's ready for review.

@nvdaes nvdaes marked this pull request as ready for review May 31, 2025 17:07
@nvdaes nvdaes requested a review from a team as a code owner May 31, 2025 17:07
@nvdaes nvdaes requested a review from seanbudd May 31, 2025 17:07
@seanbudd
Copy link
Member

seanbudd commented Jun 2, 2025

Thanks @nvdaes

@seanbudd seanbudd merged commit fcd3d44 into nvaccess:master Jun 2, 2025
15 checks passed
@github-actions github-actions bot added this to the 2025.2 milestone Jun 2, 2025
@seanbudd seanbudd linked an issue Jun 5, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use current program configuration profile in elements list

3 participants