Don't trigger a different configuration profile when Elements list or find dialogs are opened#18199
Merged
seanbudd merged 2 commits intonvaccess:masterfrom Jun 2, 2025
Merged
Conversation
Collaborator
|
Should this not also apply when opening settings pannel while focusing a an application with an active profile? |
Collaborator
Author
|
Adriani wrote: > Should this not also apply when opening settings pannel while focusing a an application with an active profile? This is the current behavior here:
|
Collaborator
Author
|
This is a very small pull request. I think that it's ready for review. |
seanbudd
approved these changes
Jun 2, 2025
Member
|
Thanks @nvdaes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes issue #18160.
Summary of the issue:
When the Elements list dialog, or the Find dialog are opened, NVDA may change the configuration profile, instead of using the current profile, for example, a profile created for the web browser. This behavior doesn't match other NVDA's dialogs, where profile triggers are suspended.
Description of user facing changes
NVDA Will use the current profile when Elements list or Find dialogs are opened.
Description of development approach
shouldSuspendConfigProfileTriggersis set to True for Elements list and Find dialogs.Testing strategy:
Windows+mto go to the desktop.Known issues with pull request:
None.
Code Review Checklist:
@coderabbitai summary