Skip to content

Revert #18271 and #18318.#18513

Merged
SaschaCowley merged 2 commits into
nvaccess:betafrom
jcsteh:revertReview
Jul 21, 2025
Merged

Revert #18271 and #18318.#18513
SaschaCowley merged 2 commits into
nvaccess:betafrom
jcsteh:revertReview

Conversation

@jcsteh
Copy link
Copy Markdown
Contributor

@jcsteh jcsteh commented Jul 21, 2025

Reverts PR

Reverts #18271 and #18318.

Issues fixed

Fixes #18498.

Issues reopened

Reopens #15159. Reopens #11285.

Reason for revert

Causes regression #18498.

Can this PR be reimplemented? If so, what is required for the next attempt

Unknown.

@jcsteh jcsteh requested a review from a team as a code owner July 21, 2025 00:58
@jcsteh jcsteh requested a review from SaschaCowley July 21, 2025 00:58
@jcsteh
Copy link
Copy Markdown
Contributor Author

jcsteh commented Jul 21, 2025

Note that #18404 was landed to fix a regression caused by #18271. However, it is independent of the code in #18271 and I think the fix in #18404 should remain anyway for correctness.

@seanbudd seanbudd added this to the 2025.2 milestone Jul 21, 2025
@SaschaCowley SaschaCowley merged commit d0210a5 into nvaccess:beta Jul 21, 2025
18 of 19 checks passed
@jcsteh jcsteh deleted the revertReview branch July 21, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants