Beta to master #18635
Merged
Beta to master #18635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed via Widows Registry (#18621) Closes #18617 Summary of the issue: In Windows 8.1, attempting to access Windows Registry to obtain update build revision (UBR) results in file not found error and the snapshot installer no longer starts. Description of user facing changes: Alpha/beta builds can be installed on Windows 8.1 again. Description of developer facing changes: If UBR cannot be obtained, build revision will be set to 0. Description of development approach: in winVersion module, put build revision assignment inside a try block, and set build revision to 0 if an exception occurs while accessing the registry. In Windows 8.1, this will result in NVDA reporting "6.3.9600.0" which is acceptable as Windows 8.1 (client version) is no longer supported by Microsoft (Windows Server 2012 R2 is supported under extended security updates program). Testing strategy: Tested in Windows 8.1 virtual machine: * nvda_snapshot_beta-51631,a18ebb3 cannot be started * nvda_snapshot_try-win81UBRRegKey-37682,e6d54c46 works normally Thanks to @wmhn1872265132 for testing Known issues with pull request: None
Amharic is a language with it's own alphabet, numerals, punctuation marks and other symbols. This list contains punctuation marks.
This pull request updates translations to languages being tracked from Crowdin. Co-authored-by: GitHub Actions <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.