Fix syntax error handling on Python 3.13 #18656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
When generating a syntax erro in a Python 3.13 Python console, the following is logged:
Description of user facing changes:
Python console no longer breaks on syntax errors on Python 3.13 builds.
Description of developer facing changes:
None
Description of development approach:
Python 3.13 added **kwargs to the
showsyntaxerrormethod. Adding this shouldn't do any harm on Python 3.11. kwargs will always be empty there and it's not problematic to pass a **kwargs to a non-kwargs supporting function when kwargs is empty.Testing strategy:
Known issues with pull request:
None
Code Review Checklist:
@coderabbitai summary