Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup of #18880
Summary of the issue:
#18880 broke signed builds, as building the controller client requires signing, and #18880 tried to build the controller client without signpath installed.
It also failed to fix #18867 properly, as the full user_docs was not built until scons launcher was called
Description of user facing changes:
None
Description of developer facing changes:
Fixed #18880 properly
Description of development approach:
Testing strategy:
Create try build
Known issues with pull request:
None
Code Review Checklist: