Skip to content

Conversation

@seanbudd
Copy link
Member

@seanbudd seanbudd commented Sep 8, 2025

Link to issue number:

Fixup of #18880

Summary of the issue:

#18880 broke signed builds, as building the controller client requires signing, and #18880 tried to build the controller client without signpath installed.

It also failed to fix #18867 properly, as the full user_docs was not built until scons launcher was called

Description of user facing changes:

None

Description of developer facing changes:

Fixed #18880 properly

Description of development approach:

  • Build all docs in a grouped job
  • Build client & launcher in a separate job

Testing strategy:

Create try build

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Copilot AI review requested due to automatic review settings September 8, 2025 06:20
@seanbudd seanbudd requested a review from a team as a code owner September 8, 2025 06:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the SCons build process by splitting targets into separate groups to fix issues with signed builds and documentation generation. The main changes separate documentation targets from launcher/client targets to ensure proper build sequencing.

  • Splits SCons targets into documentation and launcher groups
  • Moves launcher and controller client build to a separate job step with signing dependencies
  • Updates environment variables and build commands to use the new target groupings

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ci/scripts/setSconsArgs.ps1 Splits single target list into separate docs and launcher target variables
.github/workflows/testAndPublish.yml Updates workflow to build docs and launcher/client in separate steps with proper dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@seanbudd seanbudd added this to the 2025.3 milestone Sep 8, 2025
@seanbudd seanbudd changed the base branch from master to beta September 8, 2025 06:34
@seanbudd seanbudd merged commit 952953d into beta Sep 8, 2025
57 of 59 checks passed
@seanbudd seanbudd deleted the try-fix-signed-builds branch September 8, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing zh_TW docs in the latest 2025.3 beta

3 participants