Skip to content

Fix PR status checks#18895

Merged
SaschaCowley merged 4 commits into
masterfrom
fixCiTests
Sep 15, 2025
Merged

Fix PR status checks#18895
SaschaCowley merged 4 commits into
masterfrom
fixCiTests

Conversation

@SaschaCowley
Copy link
Copy Markdown
Member

@SaschaCowley SaschaCowley commented Sep 10, 2025

Link to issue number:

Fixes #18869

Summary of the issue:

Status checks are not properly enforced, meaning PRs with failing checks are allowed to be merged.

Description of user facing changes:

None

Description of developer facing changes:

CI checks must pass

Description of development approach:

Use alls-green.

Testing strategy:

Create test failures and ensure they disable merging.

I did not check po, pot, lint, types etc, however I believe that the above tests are sufficient to prove that this approach works.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@SaschaCowley SaschaCowley marked this pull request as ready for review September 10, 2025 23:13
@SaschaCowley SaschaCowley requested a review from a team as a code owner September 10, 2025 23:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes status check enforcement in the CI/CD pipeline to prevent merging PRs with failing tests. The changes implement proper status check validation using the alls-green GitHub Action and include a test case modification to verify the enforcement mechanism.

  • Replaces manual status check echo with the alls-green action for proper CI validation
  • Adds conditional execution to ensure status checks run regardless of previous job outcomes
  • Modifies a test case to create intentional failures for validation testing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/testAndPublish.yml Implements alls-green action for proper status check enforcement
tests/unit/test_addonVersionCheck.py Modifies test assertion to create intentional failure for testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/unit/test_addonVersionCheck.py Outdated
@SaschaCowley SaschaCowley marked this pull request as draft September 10, 2025 23:17
This reverts commit 6cb4d8a.

This reverts commit aaa4146.
@SaschaCowley SaschaCowley marked this pull request as ready for review September 15, 2025 00:36
@SaschaCowley SaschaCowley merged commit c18f266 into master Sep 15, 2025
40 checks passed
@SaschaCowley SaschaCowley deleted the fixCiTests branch September 15, 2025 00:44
@github-actions github-actions Bot added this to the 2026.1 milestone Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pull request status checks not correctly enforced

3 participants