Fix PR status checks#18895
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes status check enforcement in the CI/CD pipeline to prevent merging PRs with failing tests. The changes implement proper status check validation using the alls-green GitHub Action and include a test case modification to verify the enforcement mechanism.
- Replaces manual status check echo with the alls-green action for proper CI validation
- Adds conditional execution to ensure status checks run regardless of previous job outcomes
- Modifies a test case to create intentional failures for validation testing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/testAndPublish.yml | Implements alls-green action for proper status check enforcement |
| tests/unit/test_addonVersionCheck.py | Modifies test assertion to create intentional failure for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
seanbudd
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18869
Summary of the issue:
Status checks are not properly enforced, meaning PRs with failing checks are allowed to be merged.
Description of user facing changes:
None
Description of developer facing changes:
CI checks must pass
Description of development approach:
Use alls-green.
Testing strategy:
Create test failures and ensure they disable merging.
aaa4146d(CI run)6cb4d8ad(CI run)I did not check po, pot, lint, types etc, however I believe that the above tests are sufficient to prove that this approach works.
Known issues with pull request:
None
Code Review Checklist: