systemUtils.ExecAndPump: the thread handle passed to msgWaitForMultipleObjects should be a proper HANDLE not c_int. This stops the ctypes argument error, and more importantly ensures the full thread handle is represented on 64 bit.

[michaelDCurran]

Link to issue number:

Mentioned in #18914
Fixes #18911

Summary of the issue:

Creating a portable copy fails with the error

ctypes.ArgumentError: argument 2: TypeError: expected LP_c_void_p instance instead of pointer to c_long

In systemUtils.ExecAndPump: the thread is opened and the handle is stored in a c_int, but MsgWaitForMultipleObjects expects it to be aHANDLE (pointer).

Description of user facing changes:

None.

Description of developer facing changes:

Description of development approach:

threadHandle is now a HANDLE, not c_int.

Testing strategy:

• Ran the launcher and successfully created a portable copy, with no error.

Known issues with pull request:

None known.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.