Fix WindowFromAccessibleObject#18942
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the WindowFromAccessibleObject function that was introduced during the winBindings conversion of oleacc. The fix ensures proper argument types are passed to the Windows API and improves error handling.
- Fixed incorrect argument type from
c_inttoHWNDforWindowFromAccessibleObject - Improved error handling by catching specific
WindowsErrorinstead of bare except - Added debug logging for error cases and corrected a spelling error in documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/oleacc.py | Fixed argument type from c_int to HWND, added fallback return value, and corrected spelling |
| source/IAccessibleHandler/init.py | Replaced bare except with specific WindowsError handling and added debug logging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
seanbudd
reviewed
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18871
Summary of the issue:
During the winBindings conversion of oleacc, there was an oversight in passing the right argument type to WindowFromAccessibleObject.
Description of user facing changes:
#18871 no longer reproducible
Description of developer facing changes:
None
Description of development approach:
Testing strategy:
STR from #18871
Known issues with pull request:
None known
Code Review Checklist: