Fix waitable timer#18952
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes errors in braille display drivers that use waitable timers by properly casting APC functions to the required PTIMERAPCROUTINE type. The issue occurred when calling setWaitableTimer with completion routines.
- Updated
setWaitableTimerfunction to acceptPTIMERAPCROUTINEtype parameters - Added proper type casting for APC function parameters in the ioThread module
- Modernized function signature with type hints and documentation format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/winKernel.py | Updated setWaitableTimer function signature with type hints and PTIMERAPCROUTINE handling |
| source/hwIo/ioThread.py | Added explicit cast to PTIMERAPCROUTINE when calling setWaitableTimer |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #18949
Summary of the issue:
Braille display drivers that use a waitable timer to reset the waiting for acknowledgement packets timer currently raise errors.
Description of user facing changes:
NO longer errors.
Description of developer facing changes:
None
Description of development approach:
When calling
setWaitableTimer, cast the APC to typePTIMERAPCROUTINE. WhilePTIMERAPCROUTINErequires more parameters thanPAPCFUNC, we always used aPAPCFUNCinstance in the past without problems.Testing strategy:
Known issues with pull request:
None
Code Review Checklist: