Merge RC to beta #19123
Merged
Merge RC to beta #19123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary of the issue: A recent update to chrome has introduced a "Ask Google about this page" option in the omnibox (address bar). This option is sometimes spoken, even though it isn't focused, when focusing the address bar. This causes system tests which rely on Chrome to fail, as they are unable to recognise that the address bar has been focused. This breaks some tests in the Chrome, symbols, and image descriptions system test suites. ### Description of user facing changes: None. ### Description of developer facing changes: System tests work again. ### Description of development approach: When setting up a system test that uses Chrome, after sending `alt+d` to focus the address bar, if the speech is not what we expect, try reporting the focused object (`NVDA+tab`) to double-check. This works because "Address and search bar" speech is cancelled by the "Ask Google about this page" speech, so the system tests are unaware where the focus has landed. By explicitly checking the current focus, we work around this issue. ### Testing strategy: Ran the Chrome system test "checkbox labelled by inner element" locally, with and without this patch, to ensure that it was broken on my machine without the patch, and fixed with it. Ran in CI. ### Known issues with pull request: This does not fix the underlying issue, which will still likely inconvenience users. However, as this is stopping us being able to create snapshot, beta, rc or release builds, this fix needed to be prioritised.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges changes from the RC (release candidate) branch to the beta branch, incorporating bug fixes and code style improvements. The changes include a test stability enhancement for Chrome browser testing and formatting corrections for consistency with Python linting standards.
Key changes:
- Added a retry mechanism in Chrome system tests to handle intermittent UI element announcements
- Fixed trailing comma formatting in logging statements across multiple methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/system/libraries/ChromeLib.py | Added fallback logic to handle "Ask Google about this page" button interference in address bar focus detection |
| source/_remoteClient/secureDesktop.py | Added trailing commas to multi-line log statements for PEP 8 compliance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if not closeHandle(self._mapFile): | ||
| log.debugWarning( | ||
| "Failed to close handle to memory mapped IPC file. {GetLastError()}: {FormatError()}" | ||
| "Failed to close handle to memory mapped IPC file. {GetLastError()}: {FormatError()}", |
There was a problem hiding this comment.
The error message uses a plain string without f-string prefix, preventing the interpolation of {GetLastError()} and {FormatError()}. This should be changed to an f-string like the other similar log statements in this file.
Suggested change
| "Failed to close handle to memory mapped IPC file. {GetLastError()}: {FormatError()}", | |
| f"Failed to close handle to memory mapped IPC file. {GetLastError()}: {FormatError()}", |
SaschaCowley
had a problem deploying
to
production
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.