Skip to content

Increase timeout for CI/CD jobs#19221

Merged
seanbudd merged 2 commits intomasterfrom
up-build-timeout
Nov 17, 2025
Merged

Increase timeout for CI/CD jobs#19221
seanbudd merged 2 commits intomasterfrom
up-build-timeout

Conversation

@seanbudd
Copy link
Copy Markdown
Member

@seanbudd seanbudd commented Nov 17, 2025

Link to issue number:

Follow up to #19209

Summary of the issue:

We added a 10min time limit to cap and measure builds.
This was just too low, as a recent build narrowly timed out.

A similar cap for the create launcher step also is timing out: https://github.com/nvaccess/nvda/actions/runs/19415041964

Description of user facing changes:

none

Description of developer facing changes:

builds shouldnt timeout unexpectedly

Description of development approach:

increase build timeout to 15min and launcher timeout to 30min

Testing strategy:

run CI/CD

Known issues with pull request:

none

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner November 17, 2025 01:45
@seanbudd seanbudd requested review from SaschaCowley and Copilot and removed request for Copilot November 17, 2025 01:45
@seanbudd seanbudd enabled auto-merge (squash) November 17, 2025 01:45
@wmhn1872265132
Copy link
Copy Markdown
Contributor

The timeout for Create launcher should also be increased, here step took 26 minutes

@seanbudd
Copy link
Copy Markdown
Member Author

@wmhn1872265132 - wow that is much higher than usual. Do you know of any other examples of this occurring, or is that just a one off?

@wmhn1872265132
Copy link
Copy Markdown
Contributor

And here

Copilot AI review requested due to automatic review settings November 17, 2025 02:26
@seanbudd seanbudd changed the title Increase timeout for Build NVDA job to 15 minutes Increase timeout for CI/CD jobs Nov 17, 2025
@seanbudd
Copy link
Copy Markdown
Member Author

Thanks for the examples @wmhn1872265132 - I've upped the limit to 30min

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the timeout limits for CI/CD workflow jobs to prevent unexpected build timeouts following a recent build that narrowly exceeded the previous 10-minute limit.

Key changes:

  • Increased Build NVDA job timeout from 10 to 15 minutes
  • Increased Create launcher job timeout from 20 to 30 minutes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@seanbudd seanbudd disabled auto-merge November 17, 2025 03:53
@seanbudd seanbudd merged commit f4567c9 into master Nov 17, 2025
47 checks passed
@seanbudd seanbudd deleted the up-build-timeout branch November 17, 2025 03:54
@github-actions github-actions bot added this to the 2026.1 milestone Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants