Conversation
Contributor
|
The timeout for Create launcher should also be increased, here step took 26 minutes |
Member
Author
|
@wmhn1872265132 - wow that is much higher than usual. Do you know of any other examples of this occurring, or is that just a one off? |
Contributor
Member
Author
|
Thanks for the examples @wmhn1872265132 - I've upped the limit to 30min |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the timeout limits for CI/CD workflow jobs to prevent unexpected build timeouts following a recent build that narrowly exceeded the previous 10-minute limit.
Key changes:
- Increased Build NVDA job timeout from 10 to 15 minutes
- Increased Create launcher job timeout from 20 to 30 minutes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow up to #19209
Summary of the issue:
We added a 10min time limit to cap and measure builds.
This was just too low, as a recent build narrowly timed out.
A similar cap for the create launcher step also is timing out: https://github.com/nvaccess/nvda/actions/runs/19415041964
Description of user facing changes:
none
Description of developer facing changes:
builds shouldnt timeout unexpectedly
Description of development approach:
increase build timeout to 15min and launcher timeout to 30min
Testing strategy:
run CI/CD
Known issues with pull request:
none
Code Review Checklist: