Update CodeQL security analysis badge link in README#19223
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CodeQL security analysis badge URL in the README to reflect GitHub's changed URL structure for CodeQL workflows. The old URL path (github-code-scanning/codeql) has been replaced with the simpler workflow file reference (codeql.yml).
- Updated CodeQL badge and link URLs from the deprecated
github-code-scanning/codeqlpath tocodeql.yml - Simplified the badge URL structure to align with standard GitHub Actions workflow badge patterns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * Beta build status: [](https://github.com/nvaccess/nvda/actions/workflows/testAndPublish.yml?query=branch%3Abeta+event%3Apush) | ||
| * Pre-commit status (master): [](https://results.pre-commit.ci/latest/github/nvaccess/nvda/master) | ||
| * CodeQL security analysis status (master): [](https://github.com/nvaccess/nvda/actions/workflows/github-code-scanning/codeql?query=branch%3Amaster) | ||
| * CodeQL security analysis status (master): [](https://github.com/nvaccess/nvda/actions/workflows/codeql.yml) |
There was a problem hiding this comment.
The updated CodeQL badge URL is missing the branch parameter. For consistency with the other status badges in this file (Alpha and Beta build status), and since the description says "status (master)", the badge should include ?branch=master parameter:
[](https://github.com/nvaccess/nvda/actions/workflows/codeql.yml?query=branch%3Amaster)This ensures the badge specifically shows the master branch status rather than the default branch status.
Suggested change
| * CodeQL security analysis status (master): [](https://github.com/nvaccess/nvda/actions/workflows/codeql.yml) | |
| * CodeQL security analysis status (master): [](https://github.com/nvaccess/nvda/actions/workflows/codeql.yml?query=branch%3Amaster) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like GitHub changed the URL for CodeQL security analysis