Conversation
There was a problem hiding this comment.
Pull request overview
This PR documents support for the Cambodian (Khmer) language in NVDA by updating the language count and adding Cambodian to the list of supported translations in the user guide.
Changes:
- Updated the language count from 55 to 56
- Added "Cambodian" to the alphabetically-ordered list of supported languages (between Burmese and Catalan)
Comments suppressed due to low confidence (1)
user_docs/en/userGuide.md:31
- The language count on line 31 is inconsistent with the updated count on line 61. This should be changed from '55 languages' to '56 languages' to match the addition of Cambodian.
* Translated into 55 languages
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The following line of the user guide should also be updated |
|
Thanks for catching that - fixed |
|
Hi! When I started working on the Bosnian translation, I remember bringing up the question of how accurate the reported number of languages is on the translation mailing list. At the time, I also shared a list showing the translation completion percentages. It might be a good idea to open a separate issue to explain this again and keep the language count accurate and up to date. This could also help standardize how the count is determined, especially since some languages are no longer actively maintained. Thanks! |
|
@hdzrvcc0X74 - could you link your summary please? Feel free to open a new issue as well |
Link to issue number:
was blocked by #19426 and #19458
Summary of the issue:
#19458 introduced Cambodian, but we need to document it's support in NVDA
Additionally, unit tests are temporarily broken by #19458 causing an issue, with python/cpython#123853 as the root cause
Description of user facing changes:
Document cambodian support
Description of developer facing changes:
None
Description of development approach:
_LCIDS_TO_TRANSLATED_LOCALES_OVERRIDESinlanguageHandler.pyto correctly map the Windows LCID for Khmer (Cambodian), addressing upstream issues in Python's locale mapping. [1] [2]languageHandler.pyto use modern Python syntax (e.g.,str | Noneinstead ofOptional[str],list[str]instead ofList[str]). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Testing strategy:
Known issues with pull request:
Code Review Checklist: