Skip to content

document support for cambodian#19450

Merged
seanbudd merged 5 commits intobetafrom
addKm
Jan 19, 2026
Merged

document support for cambodian#19450
seanbudd merged 5 commits intobetafrom
addKm

Conversation

@seanbudd
Copy link
Member

@seanbudd seanbudd commented Jan 16, 2026

Link to issue number:

was blocked by #19426 and #19458

Summary of the issue:

#19458 introduced Cambodian, but we need to document it's support in NVDA

Additionally, unit tests are temporarily broken by #19458 causing an issue, with python/cpython#123853 as the root cause

Description of user facing changes:

Document cambodian support

Description of developer facing changes:

None

Description of development approach:

  • Introduced _LCIDS_TO_TRANSLATED_LOCALES_OVERRIDES in languageHandler.py to correctly map the Windows LCID for Khmer (Cambodian), addressing upstream issues in Python's locale mapping. [1] [2]
  • Refactored type annotations throughout languageHandler.py to use modern Python syntax (e.g., str | None instead of Optional[str], list[str] instead of List[str]). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken

Copilot AI review requested due to automatic review settings January 16, 2026 05:38
@seanbudd seanbudd requested a review from a team as a code owner January 16, 2026 05:38
@seanbudd seanbudd requested a review from Qchristensen January 16, 2026 05:38
@seanbudd seanbudd requested a review from a team as a code owner January 16, 2026 05:39
@seanbudd seanbudd requested a review from SaschaCowley January 16, 2026 05:39
@seanbudd seanbudd added this to the 2026.1 milestone Jan 16, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents support for the Cambodian (Khmer) language in NVDA by updating the language count and adding Cambodian to the list of supported translations in the user guide.

Changes:

  • Updated the language count from 55 to 56
  • Added "Cambodian" to the alphabetically-ordered list of supported languages (between Burmese and Catalan)
Comments suppressed due to low confidence (1)

user_docs/en/userGuide.md:31

  • The language count on line 31 is inconsistent with the updated count on line 61. This should be changed from '55 languages' to '56 languages' to match the addition of Cambodian.
* Translated into 55 languages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wmhn1872265132
Copy link
Contributor

The following line of the user guide should also be updated

* Translated into 55 languages

@seanbudd
Copy link
Member Author

Thanks for catching that - fixed

@tareh7z
Copy link
Contributor

tareh7z commented Jan 16, 2026

Hi!

When I started working on the Bosnian translation, I remember bringing up the question of how accurate the reported number of languages is on the translation mailing list. At the time, I also shared a list showing the translation completion percentages.

It might be a good idea to open a separate issue to explain this again and keep the language count accurate and up to date. This could also help standardize how the count is determined, especially since some languages are no longer actively maintained.

Thanks!

@seanbudd seanbudd removed the blocked label Jan 18, 2026
@seanbudd
Copy link
Member Author

@hdzrvcc0X74 - could you link your summary please? Feel free to open a new issue as well

Copy link
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SaschaCowley SaschaCowley enabled auto-merge (squash) January 19, 2026 02:07
@seanbudd seanbudd disabled auto-merge January 19, 2026 03:17
@seanbudd seanbudd merged commit ed543fa into beta Jan 19, 2026
73 of 75 checks passed
@seanbudd seanbudd deleted the addKm branch January 19, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants