Smoothing mouse magnifier and spotlight#19468
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves the smoothness of mouse magnifier movements and fixes sacading issues with spotlight animations. The changes reduce the timer refresh interval and introduce a method to bypass zoom validation during animations.
Changes:
- Reduced magnifier timer interval from 20ms to 12ms for smoother mouse tracking
- Added
_setZoomRawValue()method to allow intermediate zoom values during animations without validation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/_magnifier/magnifier.py | Reduced _TIMER_INTERVAL_MS from 20ms to 12ms and added _setZoomRawValue() method for smooth animation |
| source/_magnifier/utils/spotlightManager.py | Updated to use _setZoomRawValue() instead of the zoomLevel property setter during animation steps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SaschaCowley
added
the
conceptApproved
tareh7z
pushed a commit
to tareh7z/nvda
that referenced
this pull request
Feb 16, 2026
nvaccess#19462 Summary of the issue: Mouse movement was not smooth enough while using magnifier Spotlight steps were sacading due to zoom validation Description of user facing changes: None Description of developer facing changes: None Description of development approach: Reduce the value of refreshment for mouse Adding a function to zoom with raw values ( for animation purpose)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#19462
Summary of the issue:
Description of user facing changes:
None
Description of developer facing changes:
None
Description of development approach:
Reduce the value of refreshment for mouse
Adding a function to zoom with raw values ( for animation purpose)
Testing strategy:
Known issues with pull request:
Code Review Checklist: