Link with cetCompat flag#19469
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the /CETCOMPAT linker flag to improve security for NVDA builds on x86 and x64 architectures, as specified in issue #19435. This flag enables Control-flow Enforcement Technology (CET) compatibility, which is a hardware-assisted security feature available in modern Intel and AMD processors.
Changes:
- Added
/CETCOMPATlinker flag for x86 and x86_64 builds (excluding ARM64 and ARM64EC) - Updated copyright year to 2026
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SaschaCowley
added
the
conceptApproved
Collaborator
Author
|
According to what @mdlawler wrote in #19435 (comment), the current implementation works as expected. |
tareh7z
pushed a commit
to tareh7z/nvda
that referenced
this pull request
Feb 16, 2026
Fixes nvaccess#19435 Summary of the issue: NVDA on X86 and X64 is not linked with the /CETCOMPAT flag. This flag should improve security. Description of user facing changes: None Description of developer facing changes: None Description of development approach: Add the flag, but only on X64 and X86.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19435
Summary of the issue:
NVDA on X86 and X64 is not linked with the /CETCOMPAT flag. This flag should improve security.
Description of user facing changes:
None
Description of developer facing changes:
None
Description of development approach:
Add the flag, but only on X64 and X86.
Testing strategy:
System tests, ensured that the flag is set in binaries. See #19435 (comment)
Known issues with pull request:
None
Code Review Checklist: