Clarify error message of #19666#19690
Merged
seanbudd merged 1 commit intonvaccess:masterfrom Feb 25, 2026
Merged
Conversation
seanbudd
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of #19666
Discussed in #19666 (comment)
Summary of the issue:
The error message as written in #19666 could let think that a drive letter should be added in the portable path definition even when using
%temp%which, though, already contains it.Description of user facing changes:
Rewrote the error message.
Description of developer facing changes:
N/A
Description of development approach:
N/A
Testing strategy:
Check installer
Known issues with pull request:
None
Code Review Checklist: