Skip to content

Clarify error message of #19666#19690

Merged
seanbudd merged 1 commit intonvaccess:masterfrom
CyrilleB79:fixUp19666
Feb 25, 2026
Merged

Clarify error message of #19666#19690
seanbudd merged 1 commit intonvaccess:masterfrom
CyrilleB79:fixUp19666

Conversation

@CyrilleB79
Copy link
Copy Markdown
Contributor

Link to issue number:

Fix-up of #19666

Discussed in #19666 (comment)

Summary of the issue:

The error message as written in #19666 could let think that a drive letter should be added in the portable path definition even when using %temp% which, though, already contains it.

Description of user facing changes:

Rewrote the error message.

Description of developer facing changes:

N/A

Description of development approach:

N/A

Testing strategy:

Check installer

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 requested a review from a team as a code owner February 25, 2026 09:58
@CyrilleB79 CyrilleB79 requested a review from seanbudd February 25, 2026 09:58
@seanbudd seanbudd merged commit 888ce8a into nvaccess:master Feb 25, 2026
41 checks passed
@github-actions github-actions bot added this to the 2026.2 milestone Feb 25, 2026
@CyrilleB79 CyrilleB79 deleted the fixUp19666 branch February 26, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants