Set correct version and publisher info on synthDriver host executable#19762
Merged
SaschaCowley merged 2 commits intobetafrom Mar 10, 2026
Merged
Set correct version and publisher info on synthDriver host executable#19762SaschaCowley merged 2 commits intobetafrom
SaschaCowley merged 2 commits intobetafrom
Conversation
…xe setup.py script to dynamically set version and publisher when building via scons or CI.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the 32-bit synthDriverHost runtime build so the generated nvda_synthDriverHost.exe can embed the correct publisher and version metadata, addressing incorrect executable version info reported in #19654.
Changes:
- Add
--versionand--publishercommand-line arguments to the 32-bit runtimesetup-runtime.pybuilder. - Update SCons to pass the current build
versionandpublisherinto the runtime build step. - Update CI workflow to pass the same metadata when building the runtime during CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
sconstruct |
Passes version/publisher into the synthDriverHost32 runtime build invocation. |
runtime-builders/synthDriverHost32/setup-runtime.py |
Accepts CLI overrides for version/publisher and applies them to py2exe version_info. |
.github/workflows/testAndPublish.yml |
Passes CI version/publisher env values to the runtime builder step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SaschaCowley
requested changes
Mar 9, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SaschaCowley
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19654
Summary of the issue:
The 32 bit synthDriverhost runtime introduced in PR #19432 Does not contain correct version information in its executable.
Description of user facing changes:
Description of developer facing changes:
Description of development approach:
Testing strategy:
Known issues with pull request:
None known.
Code Review Checklist: