Skip to content

Set correct version and publisher info on synthDriver host executable#19762

Merged
SaschaCowley merged 2 commits intobetafrom
i19654
Mar 10, 2026
Merged

Set correct version and publisher info on synthDriver host executable#19762
SaschaCowley merged 2 commits intobetafrom
i19654

Conversation

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Mar 9, 2026

Link to issue number:

Fixes #19654

Summary of the issue:

The 32 bit synthDriverhost runtime introduced in PR #19432 Does not contain correct version information in its executable.

Description of user facing changes:

Description of developer facing changes:

Description of development approach:

  • synthDriverHost's setup-runtime.py py2exe script now takes version and publisher as commandline arguments, so that these can be set on the executable dynamically.
  • The github workflow and sconstruct pass the correct version and publisher to the setup-runtime.py py2exe script.

Testing strategy:

  • Locally compiled with scons synthDriverHost32Runtime, providing custom version and publisher. Confirmed that the synthDriverHost executable contains correct version and publisher information.
  • Create try bild. Confirming the same as above.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

…xe setup.py script to dynamically set version and publisher when building via scons or CI.
Copilot AI review requested due to automatic review settings March 9, 2026 06:32
@michaelDCurran michaelDCurran requested a review from a team as a code owner March 9, 2026 06:32
@michaelDCurran michaelDCurran requested a review from seanbudd March 9, 2026 06:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the 32-bit synthDriverHost runtime build so the generated nvda_synthDriverHost.exe can embed the correct publisher and version metadata, addressing incorrect executable version info reported in #19654.

Changes:

  • Add --version and --publisher command-line arguments to the 32-bit runtime setup-runtime.py builder.
  • Update SCons to pass the current build version and publisher into the runtime build step.
  • Update CI workflow to pass the same metadata when building the runtime during CI.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
sconstruct Passes version/publisher into the synthDriverHost32 runtime build invocation.
runtime-builders/synthDriverHost32/setup-runtime.py Accepts CLI overrides for version/publisher and applies them to py2exe version_info.
.github/workflows/testAndPublish.yml Passes CI version/publisher env values to the runtime builder step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@github-actions github-actions bot requested a deployment to snapshot March 9, 2026 23:50 Abandoned
@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 10, 2026
@SaschaCowley SaschaCowley merged commit 01b0001 into beta Mar 10, 2026
143 of 147 checks passed
@SaschaCowley SaschaCowley deleted the i19654 branch March 10, 2026 00:20
@github-actions github-actions bot added this to the 2026.2 milestone Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants