Skip to content

Remove empty Bangla translation#19766

Merged
seanbudd merged 3 commits intonvaccess:betafrom
CyrilleB79:remBn
Mar 10, 2026
Merged

Remove empty Bangla translation#19766
seanbudd merged 3 commits intonvaccess:betafrom
CyrilleB79:remBn

Conversation

@CyrilleB79
Copy link
Copy Markdown
Contributor

@CyrilleB79 CyrilleB79 commented Mar 9, 2026

Link to issue number:

Closes #19643

Summary of the issue:

When selecting Bangla language for NVDA, the whole interface is in English. This is because there had been an attempt to have NVDA translated in Bangla around 2022. Unfortunately, almost no translation at all has reached an NVDA release. As a result:

  1. In the Bangla interface file, no string at all is translated
  2. In the symbols.dic file, the vast majority of symbols are just English. Only 6 complex symbols have been modified. And among these 6 symbols:
    • one of them is written ". sentence ending" (with an extra space), thus it does not actually control anything
    • the decimal point just has no replacement, making the rule apparently malformed or at least un-useful and harder to understand

Description of user facing changes:

  • Bangla won't be proposed as an NVDA language in the languages list.
  • When using Bengali voice, the 4 valid Bangla/Bengali complex symbols will be reported in English. But users using Bengali voice will benefit of any change done in English symbol file since 2022 and in the future.

Description of developer facing changes:

N/A

Description of development approach:

  • Removed interface (nvda.po) and symbols files for Bangla.
  • Character description file remains unchanged. It was pre-existing 2022 translation attempt and actually contains Bangla character names. It had been introduced much earlier in NVDA with other character files for Indian family langages.

Testing strategy:

  • Check that Bangla is not offered anymore in the language list.
  • Check that starting NVDA with --lang=bn
  • Check that Bangla character description still works with eSpeak, Bengali voice.

Known issues with pull request:

None.
If someone wants to translate again NVDA to Bangla in the future, they can just do it.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 requested a review from a team as a code owner March 9, 2026 22:12
@CyrilleB79 CyrilleB79 requested a review from seanbudd March 9, 2026 22:12
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner March 9, 2026 22:59
@CyrilleB79 CyrilleB79 requested a review from Qchristensen March 9, 2026 22:59
@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 10, 2026
Comment thread user_docs/en/userGuide.md Outdated
* Ability to run entirely from a USB flash drive or other portable media without the need for installation
* Easy to use talking installer
* Translated into 56 languages
* Translated into 63 languages
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please not modify this or the list in this PR?

@seanbudd seanbudd marked this pull request as draft March 10, 2026 01:14
@seanbudd seanbudd added this to the 2026.1 milestone Mar 10, 2026
@CyrilleB79
Copy link
Copy Markdown
Contributor Author

@seanbudd can you clarify?

  • Should I remove all the changes in the User Guide? In this case, we would have the User Guide wrongly stating that we support Bangla...
  • Or just remove Bangla from the list? But in this case, should I keep 56 supported languages (which is wrong), set it to 55 (which is also wrong) or set it to 63 (which is correct but not in line with the expanded language list that follows)?
  • And if I remove some User Guide modifications from this PR, should I introduce them in another PR? Against alpha or beta?

My idea when opening this PR against beta was the following:

  1. The language list had already been modified during this beta dev cycle due to Cambodian addition.
  2. Translation freeze has not yet started. Thus some translators have not yet started translating the User Guide. Fixing the list of languages and its number of items in the same beta dev cycle would allow translators to perform only one check of this list instead of 2 in 2 different beta cycle.
  3. I have not added extra possible modification of this list that have been discussed in Clarify / fix the list of supported languages #19496 (bullet list formatting, auto-generation of the language names, etc.) since these are subject to discussion and introducing this late in the beta dev cycle may be risk (e.g. translation freeze delay).

@CyrilleB79
Copy link
Copy Markdown
Contributor Author

As an additional note.
I do not plan for now to implement an automated generation of the language list. If that's what NV Access want, I'd suggest that you open a formal issue for that, since for now, this idea is only part of what has become a discussion (#19496). Though in any case it has no sense to keep the current wrong number of languages and the incomplete list in the User Guide for the next releases.

@seanbudd
Copy link
Copy Markdown
Member

Hi @CyrilleB79 - I believe this was already discussed on #19496.
We are looking to refine the policies for including languages in the user guide.
As requested, please ensure this PR only removes Bangla.

@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Mar 10, 2026

Should I remove all the changes in the User Guide? In this case, we would have the User Guide wrongly stating that we support Bangla...
Or just remove Bangla from the list? But in this case, should I keep 56 supported languages (which is wrong), set it to 55 (which is also wrong) or set it to 63 (which is correct but not in line with the expanded language list that follows)?

Bangla was never included in this count or list. You can just remove the files without touching the user guide.

@seanbudd
Copy link
Copy Markdown
Member

And if I remove some User Guide modifications from this PR, should I introduce them in another PR? Against alpha or beta?

Please hold off on this until a policy is established

@CyrilleB79
Copy link
Copy Markdown
Contributor Author

OK, I have removed the changes in the User Guide and cleaned the initial description accordingly.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review March 10, 2026 22:01
Copy link
Copy Markdown
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit 442e584 into nvaccess:beta Mar 10, 2026
14 checks passed
@CyrilleB79 CyrilleB79 deleted the remBn branch March 11, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants