add unassigned command to report the status of screen curtain#19767
Merged
seanbudd merged 4 commits intonvaccess:masterfrom Mar 18, 2026
Merged
add unassigned command to report the status of screen curtain#19767seanbudd merged 4 commits intonvaccess:masterfrom
seanbudd merged 4 commits intonvaccess:masterfrom
Conversation
seanbudd
added
the
conceptApproved
seanbudd
reviewed
Mar 18, 2026
Added a new entry for reporting the state of the screen curtain and clarified the usage of gestures in the user guide.
seanbudd
reviewed
Mar 18, 2026
seanbudd
reviewed
Mar 18, 2026
CyrilleB79
pushed a commit
to CyrilleB79/nvda
that referenced
this pull request
Mar 18, 2026
…command: - Move this command from Vision to Misc. category - Make this command available in on-demand speak mode.
4 tasks
seanbudd
pushed a commit
that referenced
this pull request
Mar 18, 2026
…19809) Fix-up of #19767 Summary of the issue: PR #19767 has introduced a command to report the state of the screen curtain. In the Input gesture dialog, this command has been put in Vision category; that is not consistent with the screen curtain toggle command which is in the Miscellaneous category. This new command does nothing else than reporting an information, so it should be speaking when used in on-demand speech mode. Today, it does not. Description of user facing changes: In the Input gestures dialog, the "Reports the state of the screen curtain." command is now in the Miscellaneous category, as the toggle screen curtain command. Note that Screen curtain is not a visual aid, and as such, does not belong to Vision category, neither in Input gestures dialog, nor in the settings dialog. The command to report the state of the screen curtain now also speaks when in on-demand speech mode. Description of developer facing changes: None Description of development approach: Removed the "category" parameter of the @script decorator so that the command lands in misc. category. Passed the speakOnDemand=True argument to the @script decorator.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Resolves #19759
Summary of the issue:
users needs a way to know what the current status of screen curtain is
. Previously , Users had to check the NVDA settings or perform the shortcut NVDA+CTRL+ESC to know what is the current status of the screen curtain if it is activated or deactivated.
Description of user facing changes:
Now, users can assign a new custom shortcut that when it is performed will allow the users to get a notification with the current status of the screen curtain .
Description of developer facing changes:
None
Description of development approach:
Added a new intrys with an if check in /source/globalCommands.py, and added new entrys in the changes and the user docs files
Testing strategy:
tested locally
Known issues with pull request:
None
Code Review Checklist: