unlock mouse from center when panning magnifier#19782
Merged
seanbudd merged 3 commits intonvaccess:masterfrom Apr 1, 2026
Merged
unlock mouse from center when panning magnifier#19782seanbudd merged 3 commits intonvaccess:masterfrom
seanbudd merged 3 commits intonvaccess:masterfrom
Conversation
Member
|
@Boumtchack - it is becoming quite hard for us to manage so many concurrent magnifier PRs. Could you please avoid opening new ones until the current ones are complete? |
seanbudd
changed the title
seanbudd
added
the
conceptApproved
Member
|
is this ready for review? |
…fix/keepMouseCentered
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes NVDA magnifier panning so that the mouse cursor is not forcibly kept centered when the “Keep mouse pointer centered in magnifier view” setting is disabled (issue #19708).
Changes:
- Adds manual-panning state management so panning can persist without immediately snapping back to focus tracking.
- Makes mouse-centering behavior conditional (attempting to respect the “keep mouse centered” setting) and refactors this into helper methods.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
converting to draft for copilot's comments |
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Apr 2, 2026
fix a bug introduced with #19782 Summary of the issue: Mouse would drift up if shouldKeepMouseCentered=True Description of user facing changes: Mouse no more drft up
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fix #19708
Summary of the issue:
Mouse was kept in the center of the screen even if the settings was set on false
Description of user facing changes:
Keep mouse centered works properly with panning
Description of developer facing changes:
adding 2 function to better manage panning and mouse center
Description of development approach:
used better condition to update magnifier.
Testing strategy:
Manual
Known issues with pull request:
Code Review Checklist: