The Add-on Store no longer fails to reopen after an add-on installation and before NVDA restart

[CyrilleB79]

Link to issue number:

Fixes #19900

Summary of the issue:

After an add-on had been installed and the Store closed, the Store could not be reopened until NVDA was restarted.

Description of user facing changes:

The Add-on Store can now be reopened after an add-on has been installed, even before NVDA has been restarted.
For add-ons pending install, the install date is not provided since the installation is completed after NVDA has restarted.
Add-ons without install date are sorted after all other add-ons.

Description of developer facing changes:

N/A

Description of development approach:

• _AddonManifestModel.installDate now returns None if the add-on is not completely installed; take this into account when using this value.
• If the installDate is None, use datetime.max to sort the add-on after all other ones.

Testing strategy:

Manual tests:

• Tested Cannot open Add-on Store after add-on installation and before restart #19900 STR and checked details field and install date column.
• Sorted add-ons by install date column in the list.

Known issues with pull request:

None

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[CyrilleB79]

I have opened this PR against beta.
I wonder if it is an API-breaking change.
_AddonManifestModel is private, but AddonManifestModel inherits from it and is public.

And should I add an item in the change for developers (depending if it is considered API-breaking)...

[seanbudd]

I think it should be considered API breaking and a warning should happen for the highest level public classes which inherit (InstalledAddonStoreModel and AddonManifestModel)

api brk changes

[CyrilleB79]

Thanks.

In the first place, why have we made public classe inherit from private ones? This makes API checking more difficult...
To be kept in mind for future devs IMO.