Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reorganizes the Magnifier settings panel UI to better group related settings (General / Focus / Fullscreen) using static group boxes.
Changes:
- Introduces grouped sections in the Magnifier settings panel (General, Focus, Fullscreen).
- Renames/restructures several Magnifier controls and their associated help bindings.
- Adds placeholder UI entries for future “Focus” tracking options.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
@Boumtchack - please provide a descriptive title |
5 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
pre - #19473
parts of #19810
Summary of the issue:
#19810 was still to big so I focused on settingsDiallogs
Description of user facing changes:
Magnifier setttings will be better ordred with sections according to each categories
Description of developer facing changes:
Used groupbox to create groups
Description of development approach:
Separation of General settings that will impact all magnifiers, Magnifier types with their specific settings, placeholder for focus type group.
Testing strategy:
Unit
Known issues with pull request:
Code Review Checklist: