Skip to content

initial commit#19913

Closed
Boumtchack wants to merge 2 commits intonvaccess:masterfrom
France-Travail:MagnifierSettingsRework
Closed

initial commit#19913
Boumtchack wants to merge 2 commits intonvaccess:masterfrom
France-Travail:MagnifierSettingsRework

Conversation

@Boumtchack
Copy link
Copy Markdown
Contributor

Link to issue number:

pre - #19473
parts of #19810

Summary of the issue:

#19810 was still to big so I focused on settingsDiallogs

Description of user facing changes:

Magnifier setttings will be better ordred with sections according to each categories

Description of developer facing changes:

Used groupbox to create groups

Description of development approach:

Separation of General settings that will impact all magnifiers, Magnifier types with their specific settings, placeholder for focus type group.

Testing strategy:

Unit

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@Boumtchack Boumtchack marked this pull request as ready for review April 7, 2026 09:28
@Boumtchack Boumtchack requested a review from a team as a code owner April 7, 2026 09:28
@Boumtchack Boumtchack requested review from Copilot and seanbudd April 7, 2026 09:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reorganizes the Magnifier settings panel UI to better group related settings (General / Focus / Fullscreen) using static group boxes.

Changes:

  • Introduces grouped sections in the Magnifier settings panel (General, Focus, Fullscreen).
  • Renames/restructures several Magnifier controls and their associated help bindings.
  • Adds placeholder UI entries for future “Focus” tracking options.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Boumtchack Boumtchack requested a review from a team as a code owner April 7, 2026 09:58
@Boumtchack Boumtchack requested a review from Qchristensen April 7, 2026 09:58
@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Apr 7, 2026

@Boumtchack - please provide a descriptive title

@seanbudd seanbudd marked this pull request as draft April 7, 2026 23:09
@seanbudd seanbudd mentioned this pull request Apr 7, 2026
5 tasks
@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Apr 7, 2026

Let's focus on #19732 #19739 #19780 #19882 for now. Once most of these are merged, we can work on #19473 #19915 and #19913. Otherwise, there's too much conflicts between the different PRs. We want to ensure work which has already started gets completed before new work is started.

@seanbudd seanbudd closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants