Skip to content

ci: Fix inclusion of NVDA lib dll/exe/pdb files in symbols artifact.#19953

Merged
SaschaCowley merged 1 commit into
nvaccess:betafrom
jcsteh:sym
Apr 16, 2026
Merged

ci: Fix inclusion of NVDA lib dll/exe/pdb files in symbols artifact.#19953
SaschaCowley merged 1 commit into
nvaccess:betafrom
jcsteh:sym

Conversation

@jcsteh
Copy link
Copy Markdown
Contributor

@jcsteh jcsteh commented Apr 15, 2026

Link to issue number:

None.

Summary of the issue:

The symbols artifact on CI doesn't include any of the dll/exe/pdb files from NVDA's lib directory. This makes it almost impossible to debug problems in NVDA C++ code unless you are using a local build. This is particularly problematic when trying to debug nvdaHelperRemote crashes experienced by users who aren't developers.

Description of user facing changes:

None.

Description of developer facing changes:

The symbols artifact on CI now includes dll/exe/pdb files from NVDA's lib directory.

I don't think this needs a change log entry because it doesn't change anything in NVDA itself.

Description of development approach:

Once upon a time, NVDA had lib\*.dll, lib64\*.dll, etc. Some time ago, the directory structure changed to lib\x64\*.dll, lib\x86\*.dll, etc. In addition, arm64 and arm64ec libraries were added. However, the CI symbol store creation code was never updated accordingly. This PR updates the paths in the script.

Testing strategy:

Checked the log output from the Run ci/scripts/buildSymbolStore.ps1 step on GitHub actions for this pull request. Verified that it includes all files.
Also downloaded the artifact and checked that it contains all expected files.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@jcsteh
Copy link
Copy Markdown
Contributor Author

jcsteh commented Apr 15, 2026

Note that you can see that symbol files aren't being included correctly in log output for previous jobs; example:

SYMSTORE ERROR: Class: Runtime. Desc: Unable to access "source\lib64*.dll". Error 2 - SYMSTORE ERROR: Class: Runtime. Desc: Unable to access "source\lib64*.exe". Error 2 - SYMSTORE ERROR: Class: Runtime. Desc: Unable to access "source\lib64*.pdb". Error 2 -

@jcsteh jcsteh marked this pull request as ready for review April 16, 2026 03:12
@jcsteh jcsteh requested a review from a team as a code owner April 16, 2026 03:12
@jcsteh jcsteh requested a review from SaschaCowley April 16, 2026 03:12
@jcsteh
Copy link
Copy Markdown
Contributor Author

jcsteh commented Apr 16, 2026

Ideally, I think we'd get this into beta so we have symbols for 2026.1, but I don't know if that's feasible at this stage.

Copy link
Copy Markdown
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jcsteh

@SaschaCowley SaschaCowley changed the base branch from master to beta April 16, 2026 04:57
@SaschaCowley SaschaCowley requested a review from a team as a code owner April 16, 2026 04:57
@SaschaCowley SaschaCowley merged commit 3d07d82 into nvaccess:beta Apr 16, 2026
37 of 39 checks passed
@github-actions github-actions Bot added this to the 2026.2 milestone Apr 16, 2026
@seanbudd seanbudd modified the milestones: 2026.2, 2026.1 Apr 20, 2026
@jcsteh jcsteh deleted the sym branch April 20, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants