ci: Fix inclusion of NVDA lib dll/exe/pdb files in symbols artifact.#19953
Merged
Conversation
Contributor
Author
|
Note that you can see that symbol files aren't being included correctly in log output for previous jobs; example:
|
Contributor
Author
|
Ideally, I think we'd get this into beta so we have symbols for 2026.1, but I don't know if that's feasible at this stage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
The symbols artifact on CI doesn't include any of the dll/exe/pdb files from NVDA's lib directory. This makes it almost impossible to debug problems in NVDA C++ code unless you are using a local build. This is particularly problematic when trying to debug nvdaHelperRemote crashes experienced by users who aren't developers.
Description of user facing changes:
None.
Description of developer facing changes:
The symbols artifact on CI now includes dll/exe/pdb files from NVDA's lib directory.
I don't think this needs a change log entry because it doesn't change anything in NVDA itself.
Description of development approach:
Once upon a time, NVDA had
lib\*.dll,lib64\*.dll, etc. Some time ago, the directory structure changed tolib\x64\*.dll,lib\x86\*.dll, etc. In addition, arm64 and arm64ec libraries were added. However, the CI symbol store creation code was never updated accordingly. This PR updates the paths in the script.Testing strategy:
Checked the log output from the
Run ci/scripts/buildSymbolStore.ps1step on GitHub actions for this pull request. Verified that it includes all files.Also downloaded the artifact and checked that it contains all expected files.
Known issues with pull request:
None.
Code Review Checklist: