modify zoom command to start magnifier if not running#19954
Open
ethanl-11 wants to merge 2 commits intonvaccess:masterfrom
Open
modify zoom command to start magnifier if not running#19954ethanl-11 wants to merge 2 commits intonvaccess:masterfrom
ethanl-11 wants to merge 2 commits intonvaccess:masterfrom
Conversation
Author
|
The lint and license checks found a few errors, but they didn't seem to be related to the files I changed/added. I only added the two files i actually changed to be safe. There was one CI test that seemed to be failing testing the PR in my own fork, but that is not repeated here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #19624
Summary of the issue:
Magnifier does not match Windows Magnifier behavior. Attempting to "zoom in" with
NVDA+shift+pluswhile magnifier is not running results in a warning rather than starting the magnifier.Description of user facing changes:
NVDA+shift+pluscan now start the magnifier if it wasn't previously running. Keyset continues to serve as a "zoom in" command once magnifier is running.Description of developer facing changes:
None.
Description of development approach:
A check has been added to the zoom function in commands.py that will call toggleMagnifier() if the magnifier is not already active and the zoom direction is positive. Otherwise, zoom behaves as expected.
Testing strategy:
Run changes locally to manually confirm
NVDA+shift+pluswill start magnifier and ensure zoom functionality is unchanged once magnifier is running.Unit tests were also added.
Known issues with pull request:
N/A.
Code Review Checklist: