Skip to content

modify zoom command to start magnifier if not running#19954

Open
ethanl-11 wants to merge 2 commits intonvaccess:masterfrom
ethanl-11:magnifierStartWithZoom
Open

modify zoom command to start magnifier if not running#19954
ethanl-11 wants to merge 2 commits intonvaccess:masterfrom
ethanl-11:magnifierStartWithZoom

Conversation

@ethanl-11
Copy link
Copy Markdown

@ethanl-11 ethanl-11 commented Apr 16, 2026

Link to issue number:

Closes #19624

Summary of the issue:

Magnifier does not match Windows Magnifier behavior. Attempting to "zoom in" with NVDA+shift+plus while magnifier is not running results in a warning rather than starting the magnifier.

Description of user facing changes:

NVDA+shift+plus can now start the magnifier if it wasn't previously running. Keyset continues to serve as a "zoom in" command once magnifier is running.

Description of developer facing changes:

None.

Description of development approach:

A check has been added to the zoom function in commands.py that will call toggleMagnifier() if the magnifier is not already active and the zoom direction is positive. Otherwise, zoom behaves as expected.

Testing strategy:

Run changes locally to manually confirm NVDA+shift+plus will start magnifier and ensure zoom functionality is unchanged once magnifier is running.
Unit tests were also added.

Known issues with pull request:

N/A.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@ethanl-11
Copy link
Copy Markdown
Author

ethanl-11 commented Apr 16, 2026

The lint and license checks found a few errors, but they didn't seem to be related to the files I changed/added. I only added the two files i actually changed to be safe. There was one CI test that seemed to be failing testing the PR in my own fork, but that is not repeated here.

@ethanl-11 ethanl-11 marked this pull request as ready for review April 17, 2026 23:03
@ethanl-11 ethanl-11 requested a review from a team as a code owner April 17, 2026 23:03
@ethanl-11 ethanl-11 requested a review from SaschaCowley April 17, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start magnifier and zoom when pressing zoom key and magnifier not started

1 participant