Conversation
seanbudd
commented
Apr 16, 2026
| # Log at level info to ensure that the profile is logged. | ||
| log.info("Config before schema update:\n%s" % profileCopy, exc_info=False) | ||
| # Log at level debug to ensure that the profile isn't logged by default. | ||
| log.debug("Config before schema update:\n%s" % profileCopy, exc_info=False) |
Member
Author
There was a problem hiding this comment.
note this will never log at debug level on systems, as setting the log level from config hasn't happened yet, so the python default level (info) is being used.
We should avoid logging config by default, but that doesn't give good debug steps. Instead should we create a back up?
seanbudd
commented
Apr 16, 2026
Member
Author
|
Blocking on the more useful #19966 while we decide what the behaviour should be here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
getLevelNameis deprecatedDescription of user facing changes:
Description of developer facing changes:
Description of development approach:
Testing strategy:
Known issues with pull request:
log.debugwill never get logged during initialization, meaning there is no easy way to decide whether or not to log config when it fails to load.Code Review Checklist: