implementation of pinch gestures#19963
Open
kefaslungu wants to merge 3 commits intonvaccess:masterfrom
Open
Conversation
Signed-off-by: kefaslungu <jameskefaslungu@gmail.com>
Signed-off-by: kefaslungu <jameskefaslungu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#19938
Summary of the issue:
This PR adds pinch in and pinch out gestures as the first step toward expanding NVDA's touch gestures. See #19938 for more information.
Description of user facing changes:
Two new touch gestures are now available for assignment:
The fingers must move at least 50 pixels closer together or further apart to be recognised as a pinch.
Description of developer facing changes:
Description of development approach:
The pinch gesture is detected entirely within
TrackerManagerintouchTracker.py.When two fingers are on screen simultaneously, the initial distance between them is recorded.
When both fingers lift, the final distance is computed from their last known positions.
If the change in distance meets or exceeds the minimum threshold, a pinch in or pinch out
MultiTouchTrackeris queued and emitted like any other gesture.Testing strategy:
To test, you must have a touch environment, and must be able to:
Or get the snapshot
Known issues with pull request:
None.
Code Review Checklist: